Skip to content

Commit db4febf

Browse files
committed
Updated eslint-config-shakacode to 13.2.0
Big change is that trailing commas are the default for function calls. Autofixer makes this easy! Be sure to run npm run lint -- --fix and you will be updated! NOTE: Webpack config files must not have this set as of now, or else you get a syntax error. Webpack files need this, as they error if there's a trailing comma for function calls! /* eslint comma-dangle: ["error", {"functions": "never", "arrays": "only-multiline", "objects": "only-multiline"} ] */
1 parent 51188ce commit db4febf

19 files changed

+37
-18
lines changed

client/app/bundles/comments/components/CommentBox/CommentList/Comment/Comment.spec.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const {
1111
describe('Comment', () => {
1212
it('renders an author and comment with proper css classes', () => {
1313
const component = renderIntoDocument(
14-
<Comment author="Frank" text="Hi!" />
14+
<Comment author="Frank" text="Hi!" />,
1515
);
1616

1717
// TODO: Setup testing of CSS Modules classNames
@@ -25,7 +25,7 @@ describe('Comment', () => {
2525

2626
it('shows the author', () => {
2727
const component = renderIntoDocument(
28-
<Comment author="Frank" text="Hi!" />
28+
<Comment author="Frank" text="Hi!" />,
2929
);
3030

3131
const author = findRenderedDOMComponentWithClass(component, 'js-comment-author');
@@ -34,7 +34,7 @@ describe('Comment', () => {
3434

3535
it('shows the comment text in markdown', () => {
3636
const component = renderIntoDocument(
37-
<Comment author="Frank" text="Hi!" />
37+
<Comment author="Frank" text="Hi!" />,
3838
);
3939

4040
const comment = findRenderedDOMComponentWithClass(component, 'js-comment-text');

client/app/bundles/comments/components/CommentBox/CommentList/CommentList.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default class CommentList extends BaseComponent {
4444
key={$$comment.get('id') || index}
4545
author={$$comment.get('author')}
4646
text={$$comment.get('text')}
47-
/>
47+
/>,
4848
);
4949

5050
return (

client/app/bundles/comments/components/CommentBox/CommentList/CommentList.spec.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('CommentList', () => {
3636
<CommentList
3737
$$comments={comments}
3838
cssTransitionGroupClassNames={cssTransitionGroupClassNames}
39-
/>
39+
/>,
4040
);
4141
const list = scryRenderedComponentsWithType(component, Comment);
4242
expect(list.length).to.equal(2);
@@ -49,7 +49,7 @@ describe('CommentList', () => {
4949
<CommentList
5050
$$comments={comments} error="zomg"
5151
cssTransitionGroupClassNames={cssTransitionGroupClassNames}
52-
/>
52+
/>,
5353
);
5454

5555
const alert = findRenderedDOMComponentWithTag(component, 'strong');

client/app/bundles/comments/reducers/commentsReducer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default function commentsReducer($$state = $$initialState, action = null)
3737
state
3838
.updateIn(
3939
['$$comments'],
40-
$$comments => $$comments.unshift(Immutable.fromJS(comment))
40+
$$comments => $$comments.unshift(Immutable.fromJS(comment)),
4141
)
4242
.merge({
4343
submitCommentError: null,

client/app/bundles/comments/startup/ClientRouterApp.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default (_props, _railsContext) => {
1313
// Create an enhanced history that syncs navigation events with the store
1414
const history = syncHistoryWithStore(
1515
browserHistory,
16-
store
16+
store,
1717
);
1818

1919
return (

client/app/bundles/comments/startup/ClientRouterAppExpress.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const RouterAppExpress = (_props, _railsContext) => {
1818
// Create an enhanced history that syncs navigation events with the store
1919
const history = syncHistoryWithStore(
2020
browserHistory,
21-
store
21+
store,
2222
);
2323

2424
return (

client/app/bundles/comments/startup/serverRegistration.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ ReactOnRails.register(
1414
RouterApp,
1515
NavigationBarApp,
1616
SimpleCommentScreen,
17-
}
17+
},
1818
);
1919

2020
ReactOnRails.registerStore({

client/app/bundles/comments/store/commentsStore.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default (props, railsContext) => {
1515

1616
const reducer = combineReducers(reducers);
1717
const composedStore = compose(
18-
applyMiddleware(thunkMiddleware, loggerMiddleware)
18+
applyMiddleware(thunkMiddleware, loggerMiddleware),
1919
);
2020

2121
return composedStore(createStore)(reducer, initialState);

client/app/bundles/comments/store/routerCommentsStore.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export default (props, railsContext) => {
2424

2525
// Sync dispatched route actions to the history
2626
const finalCreateStore = compose(
27-
applyMiddleware(thunkMiddleware, loggerMiddleware)
27+
applyMiddleware(thunkMiddleware, loggerMiddleware),
2828
)(createStore);
2929

3030
return finalCreateStore(reducer, initialState);

client/app/libs/middlewares/loggerMiddleware.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export default function logger({ getState }) {
1515
readableState[storeItem] = (
1616
state[storeItem].toJS ? state[storeItem].toJS() : state[storeItem]
1717
);
18-
return;
1918
});
2019

2120
console.log('state after dispatch', readableState);

0 commit comments

Comments
 (0)