From 108f01182f03d45bf202f7b11786061233866443 Mon Sep 17 00:00:00 2001 From: Mostafa Ahangarha Date: Sun, 19 Nov 2023 19:27:37 +0330 Subject: [PATCH 1/2] Show first seven char of commit hash This is to follow the same convention of using commit hash so that in one glance we can detect if we are the desired commit or not. --- app/helpers/pages_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/pages_helper.rb b/app/helpers/pages_helper.rb index 3eaafbdc..51a9423f 100644 --- a/app/helpers/pages_helper.rb +++ b/app/helpers/pages_helper.rb @@ -7,6 +7,6 @@ def git_commit_sha def git_commit_sha_short full_sha = git_commit_sha - full_sha[-7..] + full_sha[...7] end end From 2a220bdcd8e0669ce8e83258f40b23f7b9545e1a Mon Sep 17 00:00:00 2001 From: Mostafa Ahangarha Date: Sun, 19 Nov 2023 19:34:33 +0330 Subject: [PATCH 2/2] Update tests --- spec/system/pages_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/system/pages_spec.rb b/spec/system/pages_spec.rb index ff8de8e8..a34147d1 100644 --- a/spec/system/pages_spec.rb +++ b/spec/system/pages_spec.rb @@ -19,7 +19,7 @@ context "when .source_version file does not exist" do let(:sha) { "94d92356828a56db25fccff9d50f41c525eead5x" } - let(:expected_text) { "5eead5x" } + let(:expected_text) { "94d9235" } before do # stub this method since we need to control what the sha actually is @@ -31,7 +31,7 @@ context "when .source_version file exists" do let(:sha) { "94d92356828a56db25fccff9d50f41c525eead5y" } - let(:expected_text) { "5eead5y" } + let(:expected_text) { "94d9235" } before { `cd #{Rails.root} && echo #{sha} > .source_version` }