Skip to content

Remove JSON0 Dependency for Client #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
curran opened this issue Mar 4, 2022 · 1 comment
Closed

Remove JSON0 Dependency for Client #548

curran opened this issue Mar 4, 2022 · 1 comment

Comments

@curran
Copy link
Contributor

curran commented Mar 4, 2022

Related to #284

Use case: I want to use the ShareDB client with JSON1, and I'm looking to generate a client build that does not contain JSON0 bundled with it.

The ShareDB client has a hard dependency on JSON0, and it's pulled in here:

https://github.com/share/sharedb/blob/master/lib/client/index.js#L5

https://github.com/share/sharedb/blob/master/lib/types.js#L2

I wonder if there might be a way to generate a browser build for the ShareDB client that does not have JSON0 bundled with it, to reduce the size of the bundle. Thanks!

@curran
Copy link
Contributor Author

curran commented Mar 19, 2022

I was able to do this in https://github.com/vizhub-core/sharedb-client-browser

Closing as the problem is solved. Feel free to comment or reopen if this is of interest inside of mainline ShareDB!

@curran curran closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant