Skip to content

Commit ba23a2f

Browse files
authored
Updated langversion to 8.0 (dotnet#4687)
* Updated langversion * Removed comment and other places where LangVersion was being set explicitly * Moved LangVersion for fsproj to Directory.Build.props
1 parent caf4b1d commit ba23a2f

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

Directory.Build.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@
9292

9393
<!-- Language configuration -->
9494
<PropertyGroup>
95-
<LangVersion>latest</LangVersion> <!-- default to allowing all language features -->
95+
<LangVersion Condition="'$(MSBuildProjectExtension)'=='.csproj'">8.0</LangVersion>
96+
<LangVersion Condition="'$(MSBuildProjectExtension)'=='.fsproj'">4.7</LangVersion>
9697
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
9798
</PropertyGroup>
9899

src/Microsoft.ML.CpuMath/Microsoft.ML.CpuMath.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
<IncludeInPackage>Microsoft.ML.CpuMath</IncludeInPackage>
66
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
77
<DefineConstants>$(DefineConstants);CPUMATH_INFRASTRUCTURE</DefineConstants>
8-
<LangVersion>7.3</LangVersion>
98
</PropertyGroup>
109

1110
<ItemGroup>

test/Microsoft.ML.Benchmarks/Microsoft.ML.Benchmarks.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<OutputType>Exe</OutputType>
4-
<LangVersion>8.0</LangVersion>
54
<GenerateProgramFile>false</GenerateProgramFile>
65
</PropertyGroup>
76
<ItemGroup>

test/Microsoft.ML.CpuMath.PerformanceTests/Microsoft.ML.CpuMath.PerformanceTests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
22
<PropertyGroup>
33
<OutputType>Exe</OutputType>
4-
<LangVersion>7.2</LangVersion>
54
<GenerateProgramFile>false</GenerateProgramFile>
65
<TargetFramework>netcoreapp3.0</TargetFramework>
76
<!--

0 commit comments

Comments
 (0)