Fixes to be compatible with Node.js 14.1.0

Author: szmarczak

package.json

@@ -62,7 +62,7 @@
 		"@types/benchmark": "^1.0.31",
 		"@types/express": "^4.17.6",
 		"@types/lolex": "^5.1.0",
-		"@types/node": "13.1.2",
+		"@types/node": "^13.13.4",
 		"@types/node-fetch": "^2.5.5",
 		"@types/request": "^2.48.4",
 		"@types/sinon": "^9.0.0",

source/core/index.ts

@@ -964,6 +964,10 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 		});
 
 		response.once('error', (error: Error) => {
+			// Force clean-up, because some packages don't do this.
+			// TODO: Fix decompress-response
+			response.destroy();
+
 			this._beforeError(new ReadError(error, this));
 		});
 
@@ -1140,6 +1144,9 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 		});
 
 		request.once('error', (error: Error) => {
+			// Force clean-up, because some packages (e.g. nock) don't do this.
+			request.destroy();
+
 			if (error instanceof TimedOutTimeoutError) {
 				error = new TimeoutError(error, this.timings!, this);
 			} else {

test/agent.ts

@@ -173,7 +173,7 @@ test('socket connect listener cleaned up after request', withServer, async (t, s
 				afterResponse: [
 					async (response, retryWithMergedOptions) => {
 						// Force clean-up
-						response.socket.destroy();
+						response.socket?.destroy();
 
 						// Unauthorized
 						if (response.statusCode === 401) {

test/retry.ts

@@ -1,4 +1,4 @@
-import EventEmitter = require('events');
+import {EventEmitter} from 'events';
 import {PassThrough as PassThroughStream} from 'stream';
 import {Socket} from 'net';
 import http = require('http');
@@ -135,6 +135,7 @@ test('custom error codes', async t => {
 			const emitter = new EventEmitter() as http.ClientRequest;
 			emitter.abort = () => {};
 			emitter.end = () => {};
+			emitter.destroy = () => {};
 
 			const error = new Error('Snap!');
 			(error as Error & {code: typeof errorCode}).code = errorCode;

test/timeout.ts

@@ -1,5 +1,5 @@
 import {promisify} from 'util';
-import EventEmitter = require('events');
+import {EventEmitter} from 'events';
 import {PassThrough as PassThroughStream} from 'stream';
 import stream = require('stream');
 import http = require('http');