From 50872589c9a29854d4701ae616df628330a67dac Mon Sep 17 00:00:00 2001
From: Ellet <echo.ellet@gmail.com>
Date: Fri, 27 Sep 2024 17:31:07 +0300
Subject: [PATCH 1/3] chore(deps): update dev dependency flutter_lints to
5.0.0, solve warnings
---
dart_quill_delta/pubspec.yaml | 1 +
example/pubspec.yaml | 2 +-
flutter_quill_extensions/lib/flutter_quill_extensions.dart | 2 +-
flutter_quill_extensions/pubspec.yaml | 2 +-
flutter_quill_test/lib/flutter_quill_test.dart | 2 +-
flutter_quill_test/pubspec.yaml | 2 +-
lib/extensions.dart | 2 +-
lib/flutter_quill.dart | 2 +-
lib/quill_delta.dart | 2 +-
lib/translations.dart | 2 +-
pubspec.yaml | 2 +-
quill_native_bridge/pubspec.yaml | 2 +-
12 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/dart_quill_delta/pubspec.yaml b/dart_quill_delta/pubspec.yaml
index 8d4072bfa..f52527a58 100644
--- a/dart_quill_delta/pubspec.yaml
+++ b/dart_quill_delta/pubspec.yaml
@@ -15,5 +15,6 @@ dependencies:
quiver: ^3.2.1
dev_dependencies:
+ # TODO: Using 4.0.0 to not require higher version of Dart SDK
lints: ^4.0.0
test: ^1.24.0
diff --git a/example/pubspec.yaml b/example/pubspec.yaml
index 5c0c784fd..b5844399c 100644
--- a/example/pubspec.yaml
+++ b/example/pubspec.yaml
@@ -66,7 +66,7 @@ dependency_overrides:
dev_dependencies:
flutter_test:
sdk: flutter
- flutter_lints: ^4.0.0
+ flutter_lints: ^5.0.0
build_runner: ^2.4.8
flutter_gen_runner: ^5.4.0
diff --git a/flutter_quill_extensions/lib/flutter_quill_extensions.dart b/flutter_quill_extensions/lib/flutter_quill_extensions.dart
index 7a9bec821..3abf9314e 100644
--- a/flutter_quill_extensions/lib/flutter_quill_extensions.dart
+++ b/flutter_quill_extensions/lib/flutter_quill_extensions.dart
@@ -1,4 +1,4 @@
-library flutter_quill_extensions;
+library;
// ignore: implementation_imports
import 'package:flutter_quill/src/editor_toolbar_controller_shared/clipboard/clipboard_service_provider.dart';
diff --git a/flutter_quill_extensions/pubspec.yaml b/flutter_quill_extensions/pubspec.yaml
index c502a0112..38d6a241d 100644
--- a/flutter_quill_extensions/pubspec.yaml
+++ b/flutter_quill_extensions/pubspec.yaml
@@ -51,7 +51,7 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
- flutter_lints: ^4.0.0
+ flutter_lints: ^5.0.0
flutter:
uses-material-design: true
diff --git a/flutter_quill_test/lib/flutter_quill_test.dart b/flutter_quill_test/lib/flutter_quill_test.dart
index 988e4e823..310ec2d05 100644
--- a/flutter_quill_test/lib/flutter_quill_test.dart
+++ b/flutter_quill_test/lib/flutter_quill_test.dart
@@ -1,3 +1,3 @@
-library flutter_quill_test;
+library;
export 'src/test/widget_tester_extension.dart';
diff --git a/flutter_quill_test/pubspec.yaml b/flutter_quill_test/pubspec.yaml
index 8247d0455..9fe894518 100644
--- a/flutter_quill_test/pubspec.yaml
+++ b/flutter_quill_test/pubspec.yaml
@@ -33,7 +33,7 @@ dependencies:
sdk: flutter
dev_dependencies:
- flutter_lints: ^4.0.0
+ flutter_lints: ^5.0.0
flutter:
uses-material-design: true
diff --git a/lib/extensions.dart b/lib/extensions.dart
index 96226bc9f..9ce60ebf1 100644
--- a/lib/extensions.dart
+++ b/lib/extensions.dart
@@ -3,7 +3,7 @@
'to expose certain internal APIs and should not be used directly, as it is subject to breaking changes.\n'
'The replacement is flutter_quill_internal.dart which is also for internal use only.',
)
-library flutter_quill.extensions;
+library;
// This file contains exports that are meant to be used
// internally and are not part of the public API as
diff --git a/lib/flutter_quill.dart b/lib/flutter_quill.dart
index 868eed6ef..2c51d6ebd 100644
--- a/lib/flutter_quill.dart
+++ b/lib/flutter_quill.dart
@@ -1,4 +1,4 @@
-library flutter_quill;
+library;
export 'src/common/structs/horizontal_spacing.dart';
export 'src/common/structs/image_url.dart';
diff --git a/lib/quill_delta.dart b/lib/quill_delta.dart
index dc3a0a01c..6418b755a 100644
--- a/lib/quill_delta.dart
+++ b/lib/quill_delta.dart
@@ -1,3 +1,3 @@
-library flutter_quill.delta;
+library;
export 'package:dart_quill_delta/dart_quill_delta.dart';
diff --git a/lib/translations.dart b/lib/translations.dart
index 2906e16c1..fe3f03591 100644
--- a/lib/translations.dart
+++ b/lib/translations.dart
@@ -1,4 +1,4 @@
-library flutter_quill.translations;
+library;
export 'src/l10n/extensions/localizations_ext.dart';
export 'src/l10n/widgets/localizations.dart';
diff --git a/pubspec.yaml b/pubspec.yaml
index 3c3b941b9..92bde70ac 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -65,7 +65,7 @@ dependencies:
quill_native_bridge: '>=10.5.14 <=10.6.2'
dev_dependencies:
- flutter_lints: ^4.0.0
+ flutter_lints: ^5.0.0
flutter_test:
sdk: flutter
flutter_quill_test: ^10.0.0
diff --git a/quill_native_bridge/pubspec.yaml b/quill_native_bridge/pubspec.yaml
index 58228fcd9..da87139e3 100644
--- a/quill_native_bridge/pubspec.yaml
+++ b/quill_native_bridge/pubspec.yaml
@@ -18,7 +18,7 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
- flutter_lints: ^4.0.0
+ flutter_lints: ^5.0.0
flutter:
plugin:
From 3a6936161ae0b34f7769273dc3ab8c1569fed705 Mon Sep 17 00:00:00 2001
From: Ellet <echo.ellet@gmail.com>
Date: Fri, 27 Sep 2024 17:34:20 +0300
Subject: [PATCH 2/3] chore: remove redundant analysis error ignore
---
analysis_options.yaml | 3 ---
flutter_quill_extensions/analysis_options.yaml | 3 ---
flutter_quill_test/analysis_options.yaml | 3 ---
3 files changed, 9 deletions(-)
diff --git a/analysis_options.yaml b/analysis_options.yaml
index 91ce64695..f9d394db2 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -1,9 +1,6 @@
include: package:flutter_lints/flutter.yaml
analyzer:
- errors:
- undefined_prefixed_name: ignore
- unsafe_html: ignore
linter:
rules:
always_declare_return_types: true
diff --git a/flutter_quill_extensions/analysis_options.yaml b/flutter_quill_extensions/analysis_options.yaml
index f1a381720..c0531f74c 100644
--- a/flutter_quill_extensions/analysis_options.yaml
+++ b/flutter_quill_extensions/analysis_options.yaml
@@ -1,9 +1,6 @@
include: package:flutter_lints/flutter.yaml
analyzer:
- errors:
- undefined_prefixed_name: ignore
- unsafe_html: ignore
linter:
rules:
always_declare_return_types: true
diff --git a/flutter_quill_test/analysis_options.yaml b/flutter_quill_test/analysis_options.yaml
index f1a381720..c0531f74c 100644
--- a/flutter_quill_test/analysis_options.yaml
+++ b/flutter_quill_test/analysis_options.yaml
@@ -1,9 +1,6 @@
include: package:flutter_lints/flutter.yaml
analyzer:
- errors:
- undefined_prefixed_name: ignore
- unsafe_html: ignore
linter:
rules:
always_declare_return_types: true
From c7605bed0c1fc3bdfd3e59659c729b5abbeb1600 Mon Sep 17 00:00:00 2001
From: Ellet <echo.ellet@gmail.com>
Date: Fri, 27 Sep 2024 17:51:54 +0300
Subject: [PATCH 3/3] chore: add avoid_web_libraries_in_flutter rule, remove
empty analyzer declaration
---
analysis_options.yaml | 2 +-
flutter_quill_extensions/analysis_options.yaml | 2 +-
flutter_quill_test/analysis_options.yaml | 2 +-
quill_native_bridge/analysis_options.yaml | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/analysis_options.yaml b/analysis_options.yaml
index f9d394db2..b6065426f 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -1,6 +1,5 @@
include: package:flutter_lints/flutter.yaml
-analyzer:
linter:
rules:
always_declare_return_types: true
@@ -30,3 +29,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
+ avoid_web_libraries_in_flutter: true
diff --git a/flutter_quill_extensions/analysis_options.yaml b/flutter_quill_extensions/analysis_options.yaml
index c0531f74c..42a46376c 100644
--- a/flutter_quill_extensions/analysis_options.yaml
+++ b/flutter_quill_extensions/analysis_options.yaml
@@ -1,6 +1,5 @@
include: package:flutter_lints/flutter.yaml
-analyzer:
linter:
rules:
always_declare_return_types: true
@@ -31,3 +30,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
+ avoid_web_libraries_in_flutter: true
diff --git a/flutter_quill_test/analysis_options.yaml b/flutter_quill_test/analysis_options.yaml
index c0531f74c..42a46376c 100644
--- a/flutter_quill_test/analysis_options.yaml
+++ b/flutter_quill_test/analysis_options.yaml
@@ -1,6 +1,5 @@
include: package:flutter_lints/flutter.yaml
-analyzer:
linter:
rules:
always_declare_return_types: true
@@ -31,3 +30,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
+ avoid_web_libraries_in_flutter: true
diff --git a/quill_native_bridge/analysis_options.yaml b/quill_native_bridge/analysis_options.yaml
index f9d394db2..b6065426f 100644
--- a/quill_native_bridge/analysis_options.yaml
+++ b/quill_native_bridge/analysis_options.yaml
@@ -1,6 +1,5 @@
include: package:flutter_lints/flutter.yaml
-analyzer:
linter:
rules:
always_declare_return_types: true
@@ -30,3 +29,4 @@ linter:
unnecessary_lambdas: true
unnecessary_parenthesis: true
unnecessary_string_interpolations: true
+ avoid_web_libraries_in_flutter: true