[Job] Show logs for all tasks of a managed job #5400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
requested changes
Apr 28, 2025
Comment on lines
+554
to
+555
| task_ids = managed_job_state.get_all_task_ids(job_id) | ||
| for job_task_id in task_ids: |
There was a problem hiding this comment.
How do people distinguish multiple tasks under a same job? Also, how do people find the previous log when the job has not finished yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5399
Show logs for all tasks of a managed job
Tested (run the relevant ones):
bash format.shLaunch a managed job with 1 task
Launch a managed job with multiple tasks
Check the job logs and the controller logs including all the tasks.
/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)