Skip to content

Commit aabd650

Browse files
authored
feat: move source files to "src" folder (#434)
1 parent 5a242c7 commit aabd650

24 files changed

+94
-81
lines changed

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenUtils.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@
3636
@SmithyUnstableApi
3737
public final class CodegenUtils {
3838

39+
public static final String SOURCE_FOLDER = "src";
40+
3941
private CodegenUtils() {}
4042

4143
/**

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenVisitor.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ void execute() {
236236
String baseName = protocol.getName().toLowerCase(Locale.US)
237237
.replace("-", "_")
238238
.replace(".", "_");
239-
String protocolTestFileName = String.format("tests/functional/%s.spec.ts", baseName);
239+
String protocolTestFileName = String.format("test/functional/%s.spec.ts", baseName);
240240
context.setDeferredWriter(() -> writers.checkoutFileWriter(protocolTestFileName));
241241
protocolGenerator.generateProtocolTests(context);
242242
}
@@ -373,7 +373,8 @@ public Void serviceShape(ServiceShape shape) {
373373

374374
if (protocolGenerator != null) {
375375
LOGGER.info("Generating serde for protocol " + protocolGenerator.getName() + " on " + shape.getId());
376-
String fileName = "protocols/" + ProtocolGenerator.getSanitizedName(protocolGenerator.getName()) + ".ts";
376+
String fileName = CodegenUtils.SOURCE_FOLDER + "/protocols/"
377+
+ ProtocolGenerator.getSanitizedName(protocolGenerator.getName()) + ".ts";
377378
writers.useFileWriter(fileName, writer -> {
378379
ProtocolGenerator.GenerationContext context = new ProtocolGenerator.GenerationContext();
379380
context.setProtocolName(protocolGenerator.getName());

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CommandGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,8 @@ private void writeSerdeDispatcher(boolean isInput) {
295295
? ProtocolGenerator.getSerFunctionName(symbol, protocolGenerator.getName())
296296
: ProtocolGenerator.getDeserFunctionName(symbol, protocolGenerator.getName());
297297
writer.addImport(serdeFunctionName, serdeFunctionName,
298-
"./protocols/" + ProtocolGenerator.getSanitizedName(protocolGenerator.getName()));
298+
"./" + CodegenUtils.SOURCE_FOLDER + "/protocols/"
299+
+ ProtocolGenerator.getSanitizedName(protocolGenerator.getName()));
299300
writer.write("return $L($L, context);", serdeFunctionName, isInput ? "input" : "output");
300301
}
301302
}

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/HttpProtocolTestGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
public final class HttpProtocolTestGenerator implements Runnable {
9090

9191
private static final Logger LOGGER = Logger.getLogger(HttpProtocolTestGenerator.class.getName());
92-
private static final String TEST_CASE_FILE_TEMPLATE = "tests/functional/%s.spec.ts";
92+
private static final String TEST_CASE_FILE_TEMPLATE = "test/functional/%s.spec.ts";
9393

9494
private final TypeScriptSettings settings;
9595
private final Model model;

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/IndexGenerator.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ static void writeIndex(
6161

6262
// write export statement for models
6363
writer.write("export * from \"./models/index\";");
64-
fileManifest.writeFile("index.ts", writer.toString());
64+
fileManifest.writeFile(CodegenUtils.SOURCE_FOLDER + "/index.ts", writer.toString());
6565
}
6666

6767
private static void writeProtocolExports(ProtocolGenerator protocolGenerator, TypeScriptWriter writer) {
@@ -89,6 +89,10 @@ static void writeServerIndex(
8989
fileManifest.writeFile("server/index.ts", writer.toString());
9090
}
9191

92+
private static String getModulePath(String fileLocation) {
93+
return fileLocation.replaceFirst(CodegenUtils.SOURCE_FOLDER, "").replace(".ts", "");
94+
}
95+
9296
private static void writeClientExports(
9397
TypeScriptSettings settings,
9498
Model model,
@@ -115,26 +119,26 @@ private static void writeClientExports(
115119
writer.write("export * from \"./commands/" + symbolProvider.toSymbol(operation).getName() + "\";");
116120
if (operation.hasTrait(PaginatedTrait.ID)) {
117121
hasPaginatedOperation = true;
118-
String modulePath = PaginationGenerator.getOutputFilelocation(operation);
119-
writer.write("export * from \"./$L\";", modulePath.replace(".ts", ""));
122+
String modulePath = getModulePath(PaginationGenerator.getOutputFilelocation(operation));
123+
writer.write("export * from \".$L\";", modulePath);
120124
}
121125
if (operation.hasTrait(WaitableTrait.ID)) {
122126
WaitableTrait waitableTrait = operation.expectTrait(WaitableTrait.class);
123127
waitableTrait.getWaiters().forEach((String waiterName, Waiter waiter) -> {
124-
String modulePath = WaiterGenerator.getOutputFileLocation(waiterName);
125-
writer.write("export * from \"./$L\";", modulePath.replace(".ts", ""));
128+
String modulePath = getModulePath(WaiterGenerator.getOutputFileLocation(waiterName));
129+
writer.write("export * from \".$L\";", modulePath);
126130
});
127131
}
128132
}
129133
if (hasPaginatedOperation) {
130-
String modulePath = PaginationGenerator.PAGINATION_INTERFACE_FILE;
131-
writer.write("export * from \"./$L\";", modulePath.replace(".ts", ""));
134+
String modulePath = getModulePath(PaginationGenerator.PAGINATION_INTERFACE_FILE);
135+
writer.write("export * from \".$L\";", modulePath);
132136
}
133137

134138
// Write each custom export.
135139
for (TypeScriptIntegration integration : integrations) {
136140
integration.writeAdditionalExports(settings, model, symbolProvider, writer);
137141
}
138-
fileManifest.writeFile("index.ts", writer.toString());
142+
fileManifest.writeFile(CodegenUtils.SOURCE_FOLDER + "/index.ts", writer.toString());
139143
}
140144
}

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/LanguageTarget.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,6 @@ String getTemplateFileName() {
6868
abstract String getTemplateFileName();
6969

7070
String getTargetFilename() {
71-
return getTemplateFileName().replace(".template", "");
71+
return CodegenUtils.SOURCE_FOLDER + "/" + getTemplateFileName().replace(".template", "");
7272
}
7373
}

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PackageJsonGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ static void writePackageJson(
5757
if (settings.generateClient()) {
5858
// Add the Node vs Browser hook.
5959
node = node.withMember("browser", Node.objectNode()
60-
.withMember("./runtimeConfig", "./runtimeConfig.browser"));
60+
.withMember("./dist-es/runtimeConfig", "./dist-es/runtimeConfig.browser"));
6161
// Add the ReactNative hook.
6262
node = node.withMember("react-native", Node.objectNode()
63-
.withMember("./runtimeConfig", "./runtimeConfig.native"));
63+
.withMember("./dist-es/runtimeConfig", "./dist-es/runtimeConfig.native"));
6464
}
6565

6666
// Set the package to private if required.

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PaginationGenerator.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
@SmithyInternalApi
3131
final class PaginationGenerator implements Runnable {
3232

33-
static final String PAGINATION_INTERFACE_FILE = "pagination/Interfaces.ts";
33+
static final String PAGINATION_INTERFACE_FILE = CodegenUtils.SOURCE_FOLDER + "/pagination/Interfaces.ts";
3434

3535
private final TypeScriptWriter writer;
3636
private final PaginationInfo paginatedInfo;
@@ -89,9 +89,7 @@ public void run() {
8989
outputSymbol.getNamespace());
9090
String nonModularLocation = serviceSymbol.getNamespace()
9191
.replace(serviceSymbol.getName(), nonModularServiceName);
92-
writer.addImport(nonModularServiceName,
93-
nonModularServiceName,
94-
nonModularLocation);
92+
writer.addImport(nonModularServiceName, nonModularServiceName, nonModularLocation);
9593
writer.addImport(serviceSymbol.getName(), serviceSymbol.getName(), serviceSymbol.getNamespace());
9694

9795
// Import Pagination types
@@ -104,7 +102,7 @@ public void run() {
104102
}
105103

106104
static String getOutputFilelocation(OperationShape operation) {
107-
return "pagination/" + operation.getId().getName() + "Paginator.ts";
105+
return CodegenUtils.SOURCE_FOLDER + "/pagination/" + operation.getId().getName() + "Paginator.ts";
108106
}
109107

110108
static void generateServicePaginationInterfaces(

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/RuntimeConfigGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,8 @@ final class RuntimeConfigGenerator {
179179
void generate(LanguageTarget target) {
180180
String template = TypeScriptUtils.loadResourceAsString(target.getTemplateFileName());
181181
String contents = template
182-
.replace("${clientModuleName}", symbolProvider.toSymbol(service).getNamespace())
182+
.replace("${clientModuleName}", symbolProvider.toSymbol(service).getNamespace()
183+
.replaceFirst(CodegenUtils.SOURCE_FOLDER + "/", ""))
183184
.replace("${clientConfigName}", symbolProvider.toSymbol(service).getName() + "Config")
184185
.replace("${apiVersion}", service.getVersion())
185186
.replace("$", "$$") // sanitize template place holders.

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/ServiceGenerator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ static String getResolvedConfigTypeName(Symbol symbol) {
9292
@Override
9393
public void run() {
9494
writer.addImport("Client", "__Client", "@aws-sdk/smithy-client");
95-
writer.addImport("getRuntimeConfig", "__getRuntimeConfig", "./runtimeConfig");
95+
writer.addImport("getRuntimeConfig", "__getRuntimeConfig",
96+
"./" + CodegenUtils.SOURCE_FOLDER + "/runtimeConfig");
9697

9798
// Normalize the input and output types of the command to account for
9899
// things like an operation adding input where there once wasn't any

0 commit comments

Comments
 (0)