From 1acc1edcebe31b435f310c79ab2889f6c2260c61 Mon Sep 17 00:00:00 2001 From: Aleksandr Buinsky Date: Wed, 13 Apr 2016 12:30:29 +0300 Subject: [PATCH 1/2] use native JSON serializing instead MessagePack is faster --- index.js | 5 ++--- package.json | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/index.js b/index.js index dddc059..dd1fc67 100644 --- a/index.js +++ b/index.js @@ -5,7 +5,6 @@ var uid2 = require('uid2'); var redis = require('redis').createClient; -var msgpack = require('msgpack-js'); var Adapter = require('socket.io-adapter'); var Emitter = require('events').EventEmitter; var debug = require('debug')('socket.io-redis'); @@ -91,7 +90,7 @@ function adapter(uri, opts){ */ Redis.prototype.onmessage = function(channel, msg){ - var args = msgpack.decode(msg); + var args = JSON.parse(msg); var packet; if (uid == args.shift()) return debug('ignore same uid'); @@ -124,7 +123,7 @@ function adapter(uri, opts){ Adapter.prototype.broadcast.call(this, packet, opts); if (!remote) { var chn = prefix + '#' + packet.nsp + '#'; - var msg = msgpack.encode([uid, packet, opts]); + var msg = JSON.stringify([uid, packet, opts]); if (opts.rooms) { opts.rooms.forEach(function(room) { var chnRoom = chn + room + '#'; diff --git a/package.json b/package.json index e01446c..4201c12 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,6 @@ "dependencies": { "async": "0.9.0", "debug": "2.2.0", - "msgpack-js": "0.3.0", "redis": "2.4.2", "socket.io-adapter": "0.4.0", "uid2": "0.0.3" From f8171ccd0eff7a45692f7ff9886ca5ee4959424d Mon Sep 17 00:00:00 2001 From: Aleksandr Buinsky Date: Wed, 13 Apr 2016 12:33:07 +0300 Subject: [PATCH 2/2] update redis dependency to latest version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 4201c12..349d4eb 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "dependencies": { "async": "0.9.0", "debug": "2.2.0", - "redis": "2.4.2", + "redis": "^2.5.3", "socket.io-adapter": "0.4.0", "uid2": "0.0.3" },