Skip to content

Commit ac46a98

Browse files
authored
travis: pin Node v8.x.x (#867)
Summary: SourceCred officially supports Node v8.x.x, so Travis should be testing against that version of Node. This fixes a cron-only, Travis-only failure. The test for the build script asserts that stderr only contains some known expected messages. On Node v10, which Travis was using, there is an additional deprecation message due to <yarnpkg/yarn#5477>. Test Plan: To see that this fixes the current cron-only build failure, add the `--full` argument to the `test` script in `package.json`, and push the resulting tree to Travis. Note that it runs `sharness-full`, which passes. wchargin-branch: travis-node-8
1 parent 778ce9e commit ac46a98

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
language: node_js
22
node_js:
3-
- "node"
3+
- "8"
44
script: yarn test
55
notifications:
66
email:

0 commit comments

Comments
 (0)