Skip to content

JRE <15 compatibility #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Strum355 opened this issue Oct 16, 2020 · 1 comment · Fixed by #65
Closed

JRE <15 compatibility #55

Strum355 opened this issue Oct 16, 2020 · 1 comment · Fixed by #65
Assignees
@Strum355
Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence type/bug Something isn't working
Milestone
3.22

Comments

@Strum355
Copy link
Contributor

Currently, comsunsource based lsif-java uses Java 15 preview features. For this reason, it cant be run where JRE version is <15. However, it must be able to do so, as most people probably run JRE<15.

Solution:

  • Migrate remaining Java code to Kotlin, which supports compiling to Java 8 bytecode while still having all the fancy fun features (and more) from Java 15
@Strum355 Strum355 added type/bug Something isn't working lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java labels Oct 16, 2020
@Strum355 Strum355 added this to the 3.22 milestone Oct 16, 2020
@Strum355 Strum355 self-assigned this Oct 16, 2020
This was referenced Oct 16, 2020
Closed
Closed
@Strum355 Strum355 mentioned this issue Oct 21, 2020
Merged
@Strum355 Strum355 linked a pull request Oct 23, 2020 that will close this issue
Complete migration to kotlin for best of both worlds #65
Merged
@Strum355
Copy link
Contributor Author

Closed in #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Strum355 Strum355

Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence type/bug Something isn't working
Projects
None yet
Milestone
3.22
Development

Successfully merging a pull request may close this issue.

Complete migration to kotlin for best of both worlds sourcegraph/scip-java
1 participant
@Strum355