Skip to content

Commit 8b9a060

Browse files
Merge pull request #708 from splitio/FME-4401-Pausing-E2E3
[FME-6995] - Pausing - E2E Test 3
2 parents 59f8302 + b2497e7 commit 8b9a060

File tree

7 files changed

+322
-61
lines changed

7 files changed

+322
-61
lines changed

Split/Storage/RuleBasedSegments/RuleBasedSegmentsStorage.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class DefaultRuleBasedSegmentsStorage: RuleBasedSegmentsStorage {
3333
}
3434

3535
func loadLocal() {
36+
segmentsInUse = persistentStorage.getSegmentsInUse()
3637
let snapshot = persistentStorage.getSnapshot()
3738
let active = snapshot.segments.filter { $0.status == .active }
3839
let archived = snapshot.segments.filter { $0.status == .archived }

Split/Storage/Splits/PersistentSplitsStorage.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protocol PersistentSplitsStorage {
1717
func getSplitsSnapshot() -> SplitsSnapshot
1818
func getChangeNumber() -> Int64
1919
func getUpdateTimestamp() -> Int64
20-
func getSegmentsInUse() -> Int64
20+
func getSegmentsInUse() -> Int64?
2121
func getAll() -> [Split]
2222
func delete(splitNames: [String])
2323
func clear()
@@ -64,8 +64,8 @@ class DefaultPersistentSplitsStorage: PersistentSplitsStorage {
6464
return generalInfoDao.stringValue(info: .flagsSpec) ?? ""
6565
}
6666

67-
func getSegmentsInUse() -> Int64 {
68-
generalInfoDao.longValue(info: .segmentsInUse) ?? 0
67+
func getSegmentsInUse() -> Int64? {
68+
generalInfoDao.longValue(info: .segmentsInUse)
6969
}
7070

7171
func update(bySetsFilter filter: SplitFilter?) {

Split/Storage/Splits/SplitsStorage.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class DefaultSplitsStorage: SplitsStorage {
5151
func loadLocal() {
5252

5353
// Ensure count of Flags with Segments (for optimization feature)
54-
segmentsInUse = persistentStorage.getSegmentsInUse()
54+
segmentsInUse = persistentStorage.getSegmentsInUse() ?? 0
5555
defer { persistentStorage.update(segmentsInUse: segmentsInUse) }
5656

5757
let snapshot = persistentStorage.getSplitsSnapshot()
@@ -98,7 +98,7 @@ class DefaultSplitsStorage: SplitsStorage {
9898
func update(splitChange: ProcessedSplitChange) -> Bool {
9999

100100
// Ensure count of Flags with Segments (for optimization feature)
101-
segmentsInUse = persistentStorage.getSegmentsInUse()
101+
segmentsInUse = persistentStorage.getSegmentsInUse() ?? 0
102102
defer { persistentStorage.update(segmentsInUse: segmentsInUse) }
103103

104104
// Process
@@ -145,6 +145,7 @@ class DefaultSplitsStorage: SplitsStorage {
145145
var splitsRemoved = false
146146

147147
for split in splits {
148+
148149
guard let splitName = split.name?.lowercased() else {
149150
Logger.e("Invalid feature flag name received while updating feature flags")
150151
continue

SplitTests/Fake/Storage/PersistentSplitsStorageStub.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class PersistentSplitsStorageStub: PersistentSplitsStorage {
9393
self.segmentsInUse = segmentsInUse
9494
}
9595

96-
func getSegmentsInUse() -> Int64 {
96+
func getSegmentsInUse() -> Int64? {
9797
getSegmentsInUseCalled = true
9898
return segmentsInUse
9999
}

SplitTests/Helpers/SplitTestHelper.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@ class SplitTestHelper {
177177
}
178178

179179
static func newSplit(name: String, trafficType: String) -> Split {
180-
181180
let splitJSONExample = """
182181
{
183182
"trafficTypeName":"\(trafficType)",

0 commit comments

Comments
 (0)