Merge pull request #549 from splitio/impression-toggle-engine

updated impressions and evaluator classes

Author: chillaq

splitio/engine/evaluator.py

@@ -67,7 +67,8 @@ def eval_with_context(self, key, bucketing, feature_name, attrs, ctx):
             'impression': {
                 'label': label,
                 'change_number': _change_number
-            }
+            },
+            'track': feature.trackImpressions
         }
 
     def _treatment_for_flag(self, flag, key, bucketing, attributes, ctx):

splitio/engine/impressions/impressions.py

@@ -11,7 +11,7 @@ class ImpressionsMode(Enum):
 class Manager(object):  # pylint:disable=too-few-public-methods
     """Impression manager."""
 
-    def __init__(self, strategy, telemetry_runtime_producer):
+    def __init__(self, strategy, none_strategy, telemetry_runtime_producer):
         """
         Construct a manger to track and forward impressions to the queue.
 
@@ -23,19 +23,33 @@ def __init__(self, strategy, telemetry_runtime_producer):
         """
 
         self._strategy = strategy
+        self._none_strategy = none_strategy
         self._telemetry_runtime_producer = telemetry_runtime_producer
 
-    def process_impressions(self, impressions):
+    def process_impressions(self, impressions_decorated):
         """
         Process impressions.
 
         Impressions are analyzed to see if they've been seen before and counted.
 
-        :param impressions: List of impression objects with attributes
-        :type impressions: list[tuple[splitio.models.impression.Impression, dict]]
+        :param impressions_decorated: List of impression objects with attributes
+        :type impressions_decorated: list[tuple[splitio.models.impression.ImpressionDecorated, dict]]
 
         :return: processed and deduped impressions.
         :rtype: tuple(list[tuple[splitio.models.impression.Impression, dict]], list(int))
         """
-        for_log, for_listener, for_counter, for_unique_keys_tracker = self._strategy.process_impressions(impressions)
-        return for_log, len(impressions) - len(for_log), for_listener, for_counter, for_unique_keys_tracker
+        for_listener_all = []
+        for_log_all = []
+        for_counter_all = []
+        for_unique_keys_tracker_all = []
+        for impression_decorated, att in impressions_decorated:
+            if not impression_decorated.track:
+                for_log, for_listener, for_counter, for_unique_keys_tracker = self._none_strategy.process_impressions([(impression_decorated.Impression, att)])
+            else:
+                for_log, for_listener, for_counter, for_unique_keys_tracker = self._strategy.process_impressions([(impression_decorated.Impression, att)])
+            for_listener_all.extend(for_listener)
+            for_log_all.extend(for_log)
+            for_counter_all.extend(for_counter)
+            for_unique_keys_tracker_all.extend(for_unique_keys_tracker)
+
+        return for_log_all, len(impressions_decorated) - len(for_log_all), for_listener_all, for_counter_all, for_unique_keys_tracker_all

tests/engine/test_evaluator.py

@@ -52,6 +52,7 @@ def test_evaluate_treatment_ok(self, mocker):
         assert result['impression']['change_number'] == 123
         assert result['impression']['label'] == 'some_label'
         assert mocked_split.get_configurations_for.mock_calls == [mocker.call('on')]
+        assert result['track'] == mocked_split.trackImpressions
 
 
     def test_evaluate_treatment_ok_no_config(self, mocker):