Skip to content

Sleuth Aware Tracing #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhenchuan9r opened this issue Jan 13, 2023 · 2 comments
Closed

Sleuth Aware Tracing #1041

zhenchuan9r opened this issue Jan 13, 2023 · 2 comments
Assignees
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@zhenchuan9r
Copy link

zhenchuan9r commented Jan 13, 2023

Expected Behavior
Endpoints, especially token endpoint activities can be traced by Sleuth.

Current Behavior
Because endpoints are implemented by filters, sleuth cannot capture requests.

Context
To implement tracing on Spring Authorization Server, Sleuth seems not currently usable.
Some other solutions, like Skywalking may be used to enforce tracing feature.
However I hope Sleuth can be the official solution.
I am using Spring Boot 2.7.x series and SAS 0.3.1.
Thanks.

@zhenchuan9r zhenchuan9r added the type: enhancement A general enhancement label Jan 13, 2023
@jgrandja
Copy link
Collaborator

@zhenchuan9r Spring Authorization Server primary purpose is to provide a light-weight and customizable foundation for building OpenID Connect 1.0 Identity Providers and OAuth2 Authorization Server products. Product specific features would need to be implemented in the consuming application. Tracing and/or eventing is a type of product feature that would need to be implemented in the consuming application. Whether the application uses Spring Cloud Sleuth or another framework/library is up to the application.

Spring Authorization Server may consider adding specific extension point(s) that would help consuming applications implement a custom tracing feature.

@jgrandja jgrandja self-assigned this Jan 16, 2023
@jgrandja jgrandja added status: declined A suggestion or change that we don't feel we should currently apply and removed type: enhancement A general enhancement labels Jan 16, 2023
@jgrandja
Copy link
Collaborator

@zhenchuan9r TRACE logging was added via gh-159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

2 participants