Skip to content

ClientSecretAuthenticationProvider inside this logic is really confusing,This makes sense(query-->validate-->modify again without making any changes)?? #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zxuanhong opened this issue May 26, 2023 · 2 comments
Assignees
Labels
for: stackoverflow A question that's better suited to stackoverflow.com

Comments

@zxuanhong
Copy link

zxuanhong commented May 26, 2023

Describe the bug

  1. ClientSecretAuthenticationProvider inside this logic is really confusing
  2. You simply validate the client, and then update the client table when the validation is successful
  3. ‘RegisteredClient registeredClient = this.registeredClientRepository.findByClientId(clientId)’There is no operation modification in the later code, so it is necessary to update later
image 4. Through the client id query, in the verification, no problem data does not make any changes to modify again????
@zxuanhong zxuanhong added the type: bug A general bug label May 26, 2023
@zxuanhong zxuanhong changed the title ClientSecretAuthenticationProvider inside this logic is really confusing,This makes sense?? ClientSecretAuthenticationProvider inside this logic is really confusing,This makes sense(Query, validate, modify again without making any changes)?? May 26, 2023
@zxuanhong zxuanhong changed the title ClientSecretAuthenticationProvider inside this logic is really confusing,This makes sense(Query, validate, modify again without making any changes)?? ClientSecretAuthenticationProvider inside this logic is really confusing,This makes sense(Query、validate、modify again without making any changes)?? May 26, 2023
@zxuanhong zxuanhong changed the title ClientSecretAuthenticationProvider inside this logic is really confusing,This makes sense(Query、validate、modify again without making any changes)?? ClientSecretAuthenticationProvider inside this logic is really confusing,This makes sense(query-->validate-->modify again without making any changes)?? May 26, 2023
@jgrandja
Copy link
Collaborator

@zxuanhong Questions are better suited to Stack Overflow. We prefer to use GitHub issues only for bugs and enhancements.

Please see gh-1099 for more details.

@jgrandja jgrandja self-assigned this May 26, 2023
@jgrandja jgrandja added for: stackoverflow A question that's better suited to stackoverflow.com and removed type: bug A general bug labels May 26, 2023
@Waylon-Firework
Copy link

#1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: stackoverflow A question that's better suited to stackoverflow.com
Projects
None yet
Development

No branches or pull requests

3 participants