Skip to content

Commit d24eb6a

Browse files
marschallfmbenhassine
authored andcommitted
Make JobParameters#getParameters() immutable
Make JobParameters#getParameters() immutable and avoid the defensive copy. Fixes #3980
1 parent 753a538 commit d24eb6a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

spring-batch-core/src/main/java/org/springframework/batch/core/JobParameters.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.batch.core;
1818

1919
import java.io.Serializable;
20+
import java.util.Collections;
2021
import java.util.Date;
2122
import java.util.LinkedHashMap;
2223
import java.util.Map;
@@ -191,7 +192,7 @@ public Date getDate(String key, @Nullable Date defaultValue){
191192
* @return an unmodifiable map containing all parameters.
192193
*/
193194
public Map<String, JobParameter> getParameters(){
194-
return new LinkedHashMap<>(parameters);
195+
return Collections.unmodifiableMap(parameters);
195196
}
196197

197198
/**

0 commit comments

Comments
 (0)