StaxEventItemReader#isFragmentRootElementName method should be protected

[spring-projects-issues]

Balan opened BATCH-2583 and commented

I was looking up to customize the method moveCursorToNextFragment in StaxEventItemReader and I noticed this method uses isFragmentRootElementName which is currently a private method. In my opinion, if caller is 'protected', the callee should have been made 'protected' as well.

---

Affects: 3.0.7

[fmbenhassine]

In my opinion, if caller is 'protected', the callee should have been made 'protected' as well.

That's not necessarily true, because if that private method calls another private method which in turn calls yet another private method, we would transitively need to make all of them protected and end up opening the entire class for extension.

As a second example, the jumpToItem is protected and calls readToStartFragment and readToEndFragment which are private. I don't think these two methods should necessarily be made protected.

That said, I see an added value in making StaxEventItemReader#isFragmentRootElementName protected to be able to override the logic in there.