Skip to content

Deprecate JobExecution#stop() for removal #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Mar 26, 2013 · 1 comment
Closed

Deprecate JobExecution#stop() for removal #1605

spring-projects-issues opened this issue Mar 26, 2013 · 1 comment
Labels
in: core type: task
Milestone
4.3.0

Comments

@spring-projects-issues
Copy link
Collaborator

Michael Minella opened BATCH-1987 and commented

No further details from BATCH-1987
@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Nov 9, 2018 •
edited by fmbenhassine
Loading

Mahmoud Ben Hassine commented

@Michael Minella What is the motivation behind this? I believe it's because client code should not call the method directly on the jobExecution (which is prone to forgetting to save the updated jobExecution in the job repository) but should use org.springframework.batch.core.launch.JobOperator#stop instead. Is that correct?

@fmbenhassine fmbenhassine changed the title Remove JobExecution#stop() [BATCH-1987] Deprecate JobExecution#stop() for removal [BATCH-1987] Jan 20, 2020
@fmbenhassine fmbenhassine added this to the 4.3.0 milestone Jan 20, 2020
@fmbenhassine fmbenhassine removed the status: waiting-for-triage Issues that we did not analyse yet label Jan 20, 2020
@fmbenhassine fmbenhassine changed the title Deprecate JobExecution#stop() for removal [BATCH-1987] Deprecate JobExecution#stop() for removal Sep 15, 2020
@fmbenhassine fmbenhassine mentioned this issue Sep 15, 2020
Closed
@fmbenhassine fmbenhassine mentioned this issue May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core type: task
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@fmbenhassine @spring-projects-issues