Skip to content

Deprecate ScheduledJobParametersFactory #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fmbenhassine opened this issue Sep 16, 2020 · 0 comments
Closed

Deprecate ScheduledJobParametersFactory #3781

fmbenhassine opened this issue Sep 16, 2020 · 0 comments
Labels
in: core
Milestone
4.3.0

Comments

@fmbenhassine
Copy link
Contributor

ScheduledJobParametersFactory has no added value other than formatting/parsing a date property (which is hardcoded to schedule.date). This is already provided by the DefaultJobParametersConverter. Moreover, it is inconsistent with the DefaultJobParametersConverter where the parameter type is expected to be specified as a prefix like schedule.date(date) (See Javadoc).

ScheduledJobParametersFactory should be deprecated in favour of DefaultJobParametersConverter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
1 participant
@fmbenhassine