Skip to content

Unnecessary apache commons-io dependency in spring-batch-test module [BATCH-2698] #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Mar 7, 2018 · 0 comments
Closed

Unnecessary apache commons-io dependency in spring-batch-test module [BATCH-2698] #909

spring-projects-issues opened this issue Mar 7, 2018 · 0 comments
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: test type: enhancement
Milestone
4.1.0

Comments

@spring-projects-issues
Copy link
Collaborator

Mahmoud Ben Hassine opened BATCH-2698 and commented

The only usage of apache commons io library in spring-batch-test module is in DataSourceInitializer:

scripts = StringUtils.delimitedListToStringArray(stripComments(IOUtils.readLines(scriptResource
							.getInputStream(), "UTF-8")), ";");

Now that v4 is based on Java 8, IOUtils.readLines can be replaced with Files.lines and the dependency to commons io can be removed.

Affects: 4.0.1

Referenced from: pull request #587, and commits 305b4b8, f552607

Backported to: 4.1.0.M3, 4.0.2
@spring-projects-issues spring-projects-issues added in: test has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" type: enhancement labels Dec 16, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.0 milestone Dec 16, 2019
This was referenced Dec 17, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has: backports Legacy label from JIRA. Superseded by "for: backport-to-x.x.x" in: test type: enhancement
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
1 participant
@spring-projects-issues