Skip to content

Bring JobLauncherCommandLineRunner#getNextJobParameters to Batch [BATCH-2640] #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Sep 8, 2017 · 2 comments
Closed

Bring JobLauncherCommandLineRunner#getNextJobParameters to Batch [BATCH-2640] #963

spring-projects-issues opened this issue Sep 8, 2017 · 2 comments
Labels
in: core type: enhancement
Milestone
4.0.0.M4

Comments

@spring-projects-issues
Copy link
Collaborator

Michael Minella opened BATCH-2640 and commented

The users of Batch typically need to manage the job parameter logic themselves. It would be nice to provide some functionality out of the box to simplify this exercise. Spring Boot has a good example in the JobLauncherCommandLineRunner#getNextParameters method that could move over.

Affects: 3.0.7

Reference URL: spring-projects/spring-boot#10135

Referenced from: commits a35784d
@spring-projects-issues
Copy link
Collaborator Author

diego lovison commented

The private method

JobParameters merge(JobParameters parameters, Map<String, JobParameter> additionals)

on class

JobLauncherCommandLineRunner

is a good candidate to be public as well.

@spring-projects-issues
Copy link
Collaborator Author

Michael Minella commented

Resolved via a35784d

@spring-projects-issues spring-projects-issues added this to the 4.0.0.M4 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core type: enhancement
Projects
None yet
Milestone
4.0.0.M4
Development

No branches or pull requests
1 participant
@spring-projects-issues