From b357de2c2232658a053074044777ac8dd3758022 Mon Sep 17 00:00:00 2001 From: Philippe Marschall Date: Wed, 1 Sep 2021 14:31:53 +0200 Subject: [PATCH] Make JobParameters#getParameters() immutable Make JobParameters#getParameters() immutable and avoid the defensive copy. Fixes #3980 --- .../java/org/springframework/batch/core/JobParameters.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/JobParameters.java b/spring-batch-core/src/main/java/org/springframework/batch/core/JobParameters.java index bde6eea910..237fed7f81 100644 --- a/spring-batch-core/src/main/java/org/springframework/batch/core/JobParameters.java +++ b/spring-batch-core/src/main/java/org/springframework/batch/core/JobParameters.java @@ -17,6 +17,7 @@ package org.springframework.batch.core; import java.io.Serializable; +import java.util.Collections; import java.util.Date; import java.util.LinkedHashMap; import java.util.Map; @@ -191,7 +192,7 @@ public Date getDate(String key, @Nullable Date defaultValue){ * @return an unmodifiable map containing all parameters. */ public Map getParameters(){ - return new LinkedHashMap<>(parameters); + return Collections.unmodifiableMap(parameters); } /**