From 87d67a179f0dab6ef3fc0f07aecf43419afe05dd Mon Sep 17 00:00:00 2001 From: ParadiseCHOI Date: Thu, 30 Sep 2021 07:52:36 +0900 Subject: [PATCH 1/3] Modify unnecessary parameter expression, list.add(future.get()) to list.add(item) --- .../batch/integration/async/AsyncItemWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java b/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java index 1df06bff1c..17641a84ac 100644 --- a/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java +++ b/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java @@ -65,7 +65,7 @@ public void write(List> items) throws Exception { T item = future.get(); if(item != null) { - list.add(future.get()); + list.add(item); } } catch (ExecutionException e) { From ac7c6f6d12404f70a4f28711a2770a56d13719f2 Mon Sep 17 00:00:00 2001 From: ParadiseCHOI Date: Thu, 30 Sep 2021 07:54:24 +0900 Subject: [PATCH 2/3] Modify unnecessary conditional expression, if (cause != null && cause instanceof Exception) to if (cause instanceof Exception) --- .../batch/integration/async/AsyncItemWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java b/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java index 17641a84ac..b6d7aa7855 100644 --- a/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java +++ b/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java @@ -71,7 +71,7 @@ public void write(List> items) throws Exception { catch (ExecutionException e) { Throwable cause = e.getCause(); - if(cause != null && cause instanceof Exception) { + if(cause instanceof Exception) { logger.debug("An exception was thrown while processing an item", e); throw (Exception) cause; From cc8ce8beebf764b586240944cc0e9baaa3bb715e Mon Sep 17 00:00:00 2001 From: ParadiseCHOI Date: Thu, 30 Sep 2021 07:55:55 +0900 Subject: [PATCH 3/3] Add conditional expression when list is empty --- .../batch/integration/async/AsyncItemWriter.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java b/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java index b6d7aa7855..415d3ad4cf 100644 --- a/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java +++ b/spring-batch-integration/src/main/java/org/springframework/batch/integration/async/AsyncItemWriter.java @@ -81,8 +81,10 @@ public void write(List> items) throws Exception { } } } - - delegate.write(list); + + if (!list.isEmpty()) { + delegate.write(list); + } } @Override