Skip to content

Commit 08b9d1d

Browse files
committed
Polish "Ensure that MeterRegistry bean is defined before SI looks for it"
See gh-24095
1 parent 7d712aa commit 08b9d1d

File tree

3 files changed

+9
-19
lines changed

3 files changed

+9
-19
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/integration/IntegrationMetricsAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,10 @@
3333
* for it.
3434
*
3535
* @author Andy Wilkinson
36-
* @since 2.3.6
3736
*/
3837
@AutoConfigureAfter({ MetricsAutoConfiguration.class, CompositeMeterRegistryAutoConfiguration.class })
3938
@AutoConfigureBefore(IntegrationAutoConfiguration.class)
4039
@Configuration(proxyBeanMethods = false)
41-
public class IntegrationMetricsAutoConfiguration {
40+
class IntegrationMetricsAutoConfiguration {
4241

4342
}

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/resources/META-INF/spring.factories

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ org.springframework.boot.actuate.autoconfigure.metrics.export.signalfx.SignalFxM
6565
org.springframework.boot.actuate.autoconfigure.metrics.export.simple.SimpleMetricsExportAutoConfiguration,\
6666
org.springframework.boot.actuate.autoconfigure.metrics.export.statsd.StatsdMetricsExportAutoConfiguration,\
6767
org.springframework.boot.actuate.autoconfigure.metrics.export.wavefront.WavefrontMetricsExportAutoConfiguration,\
68-
org.springframework.boot.actuate.autoconfigure.metrics.jdbc.DataSourcePoolMetricsAutoConfiguration,\
6968
org.springframework.boot.actuate.autoconfigure.metrics.integration.IntegrationMetricsAutoConfiguration,\
69+
org.springframework.boot.actuate.autoconfigure.metrics.jdbc.DataSourcePoolMetricsAutoConfiguration,\
7070
org.springframework.boot.actuate.autoconfigure.metrics.jersey.JerseyServerMetricsAutoConfiguration,\
7171
org.springframework.boot.actuate.autoconfigure.metrics.orm.jpa.HibernateMetricsAutoConfiguration,\
7272
org.springframework.boot.actuate.autoconfigure.metrics.web.client.HttpClientMetricsAutoConfiguration,\

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/integration/IntegrationMetricsAutoConfigurationTests.java

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616

1717
package org.springframework.boot.actuate.autoconfigure.metrics.integration;
1818

19-
19+
import io.micrometer.core.instrument.Gauge;
20+
import io.micrometer.core.instrument.MeterRegistry;
2021
import org.junit.jupiter.api.Test;
2122

2223
import org.springframework.boot.actuate.autoconfigure.integration.IntegrationGraphEndpointAutoConfiguration;
@@ -26,35 +27,25 @@
2627
import org.springframework.boot.autoconfigure.integration.IntegrationAutoConfiguration;
2728
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2829

29-
import io.micrometer.core.instrument.Gauge;
30-
import io.micrometer.core.instrument.MeterRegistry;
31-
3230
import static org.assertj.core.api.Assertions.assertThat;
3331

3432
/**
3533
* Tests for {@link RabbitMetricsAutoConfiguration}.
3634
*
3735
* @author Artem Bilan
38-
* @since 2.3.6
3936
*/
4037
class IntegrationMetricsAutoConfigurationTests {
4138

42-
private final ApplicationContextRunner contextRunner =
43-
new ApplicationContextRunner()
44-
.withConfiguration(AutoConfigurations.of(
45-
IntegrationAutoConfiguration.class,
46-
IntegrationGraphEndpointAutoConfiguration.class))
47-
.with(MetricsRun.simple())
48-
.withPropertyValues("management.metrics.tags.someTag=someValue");
39+
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
40+
.withConfiguration(AutoConfigurations.of(IntegrationAutoConfiguration.class,
41+
IntegrationGraphEndpointAutoConfiguration.class, IntegrationMetricsAutoConfiguration.class))
42+
.with(MetricsRun.simple()).withPropertyValues("management.metrics.tags.someTag=someValue");
4943

5044
@Test
5145
void integrationMetersAreInstrumented() {
5246
this.contextRunner.run((context) -> {
5347
MeterRegistry registry = context.getBean(MeterRegistry.class);
54-
Gauge gauge =
55-
registry.get("spring.integration.channels")
56-
.tag("someTag", "someValue")
57-
.gauge();
48+
Gauge gauge = registry.get("spring.integration.channels").tag("someTag", "someValue").gauge();
5849
assertThat(gauge).isNotNull().extracting(Gauge::value).isEqualTo(2.0);
5950
});
6051
}

0 commit comments

Comments
 (0)