Skip to content

Commit 6e1b28e

Browse files
committed
Relocate MimeMapping Tomcat comparison test
See gh-32101
1 parent dd98b88 commit 6e1b28e

File tree

2 files changed

+14
-17
lines changed

2 files changed

+14
-17
lines changed

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/server/MimeMappingsTests.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,24 @@
1616

1717
package org.springframework.boot.web.server;
1818

19+
import java.io.IOException;
1920
import java.util.ArrayList;
2021
import java.util.HashMap;
2122
import java.util.List;
2223
import java.util.Map;
24+
import java.util.Properties;
2325
import java.util.regex.Pattern;
2426

27+
import org.apache.catalina.startup.Tomcat;
2528
import org.junit.jupiter.api.Test;
2629

2730
import org.springframework.aot.hint.RuntimeHints;
2831
import org.springframework.aot.hint.predicate.RuntimeHintsPredicates;
2932
import org.springframework.boot.web.server.MimeMappings.DefaultMimeMappings;
3033
import org.springframework.boot.web.server.MimeMappings.Mapping;
3134
import org.springframework.boot.web.server.MimeMappings.MimeMappingsRuntimeHints;
35+
import org.springframework.core.io.ClassPathResource;
36+
import org.springframework.core.io.support.PropertiesLoaderUtils;
3237
import org.springframework.test.util.ReflectionTestUtils;
3338

3439
import static org.assertj.core.api.Assertions.assertThat;
@@ -210,6 +215,15 @@ void lazyCopyWhenMutatedCreatesCopyOnlyOnce() {
210215
assertThat(lazyCopy.get("json")).isEqualTo("other/json");
211216
}
212217

218+
@Test
219+
void mimeMappingsMatchesTomcatDefaults() throws IOException {
220+
Properties ourDefaultMimeMappings = PropertiesLoaderUtils
221+
.loadProperties(new ClassPathResource("mime-mappings.properties", getClass()));
222+
Properties tomcatDefaultMimeMappings = PropertiesLoaderUtils
223+
.loadProperties(new ClassPathResource("MimeTypeMappings.properties", Tomcat.class));
224+
assertThat(ourDefaultMimeMappings).isEqualTo(tomcatDefaultMimeMappings);
225+
}
226+
213227
@Test
214228
void shouldRegisterHints() {
215229
RuntimeHints runtimeHints = new RuntimeHints();

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactoryTests.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
import java.util.Locale;
4646
import java.util.Map;
4747
import java.util.Objects;
48-
import java.util.Properties;
4948
import java.util.concurrent.ArrayBlockingQueue;
5049
import java.util.concurrent.BlockingQueue;
5150
import java.util.concurrent.Callable;
@@ -78,7 +77,6 @@
7877
import jakarta.servlet.http.HttpServletRequest;
7978
import jakarta.servlet.http.HttpServletResponse;
8079
import jakarta.servlet.http.HttpSession;
81-
import org.apache.catalina.startup.Tomcat;
8280
import org.apache.catalina.webresources.TomcatURLStreamHandlerFactory;
8381
import org.apache.http.HttpResponse;
8482
import org.apache.http.client.HttpClient;
@@ -136,7 +134,6 @@
136134
import org.springframework.core.io.ClassPathResource;
137135
import org.springframework.core.io.FileSystemResource;
138136
import org.springframework.core.io.Resource;
139-
import org.springframework.core.io.support.PropertiesLoaderUtils;
140137
import org.springframework.http.HttpMethod;
141138
import org.springframework.http.HttpStatus;
142139
import org.springframework.http.client.ClientHttpRequest;
@@ -961,20 +958,6 @@ void mimeMappingsAreCorrectlyConfigured() {
961958
assertThat(configuredMimeMappings.size()).isEqualTo(expectedMimeMappings.size());
962959
}
963960

964-
@Test
965-
void mimeMappingsContainsDefaultsOfTomcat() throws IOException {
966-
AbstractServletWebServerFactory factory = getFactory();
967-
this.webServer = factory.getWebServer();
968-
Map<String, String> configuredMimeMappings = getActualMimeMappings();
969-
// override defaults, see org.apache.catalina.startup.MimeTypeMappings.properties
970-
Properties tomcatDefaultMimeMappings = PropertiesLoaderUtils
971-
.loadProperties(new ClassPathResource("MimeTypeMappings.properties", Tomcat.class));
972-
for (String extension : tomcatDefaultMimeMappings.stringPropertyNames()) {
973-
assertThat(configuredMimeMappings).containsEntry(extension,
974-
tomcatDefaultMimeMappings.getProperty(extension));
975-
}
976-
}
977-
978961
@Test
979962
void rootServletContextResource() {
980963
AbstractServletWebServerFactory factory = getFactory();

0 commit comments

Comments
 (0)