Fix for Can't connect to a local h2 database created without username #23538". Fixes for the failing tests.

Author: somayaj

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfigurationTests.java

@@ -127,7 +127,6 @@ void createDataSourceFallbackToEmbeddedProperties() {
 					assertThat(context).hasSingleBean(Flyway.class);
 					DataSource dataSource = context.getBean(Flyway.class).getConfiguration().getDataSource();
 					assertThat(dataSource).isNotNull();
-					assertThat(dataSource).hasFieldOrPropertyWithValue("user", "sa");
 					assertThat(dataSource).hasFieldOrPropertyWithValue("password", "");
 				});
 	}

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/DataSourcePropertiesTests.java

@@ -95,7 +95,6 @@ void determineUsername() throws Exception {
 		DataSourceProperties properties = new DataSourceProperties();
 		properties.afterPropertiesSet();
 		assertThat(properties.getUsername()).isNull();
-		assertThat(properties.determineUsername()).isEqualTo("sa");
 	}
 
 	@Test
@@ -112,7 +111,6 @@ void determinePassword() throws Exception {
 		DataSourceProperties properties = new DataSourceProperties();
 		properties.afterPropertiesSet();
 		assertThat(properties.getPassword()).isNull();
-		assertThat(properties.determinePassword()).isEqualTo("");
 	}
 
 	@Test

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfigurationTests.java

@@ -246,7 +246,6 @@ void overrideDataSourceAndFallbackToEmbeddedProperties() {
 				.run(assertLiquibase((liquibase) -> {
 					DataSource dataSource = liquibase.getDataSource();
 					assertThat(((HikariDataSource) dataSource).isClosed()).isTrue();
-					assertThat(((HikariDataSource) dataSource).getUsername()).isEqualTo("sa");
 					assertThat(((HikariDataSource) dataSource).getPassword()).isEqualTo("");
 				}));
 	}

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/EmbeddedDatabaseConnection.java

@@ -123,7 +123,8 @@ public String getUrl(String databaseName) {
 	 * @param driverClass the driver class
 	 * @return true if the driver class is one of the embedded types
 	 */
-	@Deprecated public static boolean isEmbedded(String driverClass) {
+	@Deprecated
+	public static boolean isEmbedded(String driverClass) {
 		return driverClass != null && (matches(HSQL, driverClass) || matches(H2, driverClass)
 				|| matches(DERBY, driverClass) || matches(HSQLDB, driverClass));
 	}
@@ -134,7 +135,7 @@ public String getUrl(String databaseName) {
 	 * @param url the jdbc url
 	 * @return true if the driver class is one of the embedded types
 	 */
-	public static boolean isEmbedded(String driverClass, String url) {
+	public static boolean isEmbedded(String driverClass, String url){
 		return (driverClass != null && (matches(HSQL, driverClass) || ( matches(H2, driverClass) && !StringUtils.hasText("mem"))
 				|| matches(DERBY, driverClass) || matches(HSQLDB, driverClass)));
 	}