Skip to content

Commit fa336bb

Browse files
committed
Move DataSource dependency detection into dedicated package
Closes gh-25757
1 parent a900306 commit fa336bb

File tree

29 files changed

+41
-42
lines changed

29 files changed

+41
-42
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
import org.springframework.boot.context.properties.PropertyMapper;
5151
import org.springframework.boot.jdbc.DataSourceBuilder;
5252
import org.springframework.boot.jdbc.DatabaseDriver;
53-
import org.springframework.boot.jdbc.init.DataSourceInitializationDependencyConfigurer;
53+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializationDependencyConfigurer;
5454
import org.springframework.context.annotation.Bean;
5555
import org.springframework.context.annotation.Conditional;
5656
import org.springframework.context.annotation.Configuration;

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayMigrationInitializerDataSourceInitializerDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
import java.util.Collections;
2020
import java.util.Set;
2121

22-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDataSourceInitializerDetector;
23-
import org.springframework.boot.jdbc.init.DataSourceInitializerDetector;
22+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDataSourceInitializerDetector;
23+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializerDetector;
2424

2525
/**
2626
* A {@link DataSourceInitializerDetector} for {@link FlywayMigrationInitializer}.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceInitializationConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import javax.sql.DataSource;
2020

2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnSingleCandidate;
22-
import org.springframework.boot.jdbc.init.DataSourceInitializationDependencyConfigurer;
22+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializationDependencyConfigurer;
2323
import org.springframework.context.annotation.Bean;
2424
import org.springframework.context.annotation.Configuration;
2525
import org.springframework.context.annotation.Import;

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceInitializationDataSourceInitializerDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
import java.util.Collections;
2020
import java.util.Set;
2121

22-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDataSourceInitializerDetector;
23-
import org.springframework.boot.jdbc.init.DataSourceInitializerDetector;
22+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDataSourceInitializerDetector;
23+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializerDetector;
2424

2525
/**
2626
* A {@link DataSourceInitializerDetector} for {@link DataSourceInitialization}.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/JdbcOperationsDependsOnPostProcessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import org.springframework.beans.factory.config.BeanDefinition;
2020
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
2121
import org.springframework.boot.autoconfigure.AbstractDependsOnBeanFactoryPostProcessor;
22-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitializationDetector;
22+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitializationDetector;
2323
import org.springframework.jdbc.core.JdbcOperations;
2424

2525
/**

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/JdbcTemplateAutoConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2424
import org.springframework.boot.autoconfigure.condition.ConditionalOnSingleCandidate;
2525
import org.springframework.boot.context.properties.EnableConfigurationProperties;
26-
import org.springframework.boot.jdbc.init.DataSourceInitializationDependencyConfigurer;
26+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializationDependencyConfigurer;
2727
import org.springframework.context.annotation.Configuration;
2828
import org.springframework.context.annotation.Import;
2929
import org.springframework.jdbc.core.JdbcTemplate;

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/NamedParameterJdbcOperationsDependsOnPostProcessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import org.springframework.beans.factory.config.BeanDefinition;
2020
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
2121
import org.springframework.boot.autoconfigure.AbstractDependsOnBeanFactoryPostProcessor;
22-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitializationDetector;
22+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitializationDetector;
2323
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcOperations;
2424

2525
/**

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jooq/DslContextDependsOnPostProcessor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import org.springframework.beans.factory.config.BeanDefinition;
2222
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
2323
import org.springframework.boot.autoconfigure.AbstractDependsOnBeanFactoryPostProcessor;
24-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitializationDetector;
24+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitializationDetector;
2525

2626
/**
2727
* {@link BeanFactoryPostProcessor} that can be used to dynamically declare that all

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import org.springframework.boot.autoconfigure.orm.jpa.HibernateJpaAutoConfiguration;
3535
import org.springframework.boot.context.properties.EnableConfigurationProperties;
3636
import org.springframework.boot.jdbc.DataSourceBuilder;
37-
import org.springframework.boot.jdbc.init.DataSourceInitializationDependencyConfigurer;
37+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializationDependencyConfigurer;
3838
import org.springframework.context.annotation.Bean;
3939
import org.springframework.context.annotation.Conditional;
4040
import org.springframework.context.annotation.Configuration;

spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/spring.factories

+1-2
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ org.springframework.boot.autoconfigure.thymeleaf.ThymeleafTemplateAvailabilityPr
168168
org.springframework.boot.autoconfigure.web.servlet.JspTemplateAvailabilityProvider
169169

170170
# DataSource initializer detectors
171-
org.springframework.boot.jdbc.init.DataSourceInitializerDetector=\
171+
org.springframework.boot.jdbc.init.dependency.DataSourceInitializerDetector=\
172172
org.springframework.boot.autoconfigure.flyway.FlywayMigrationInitializerDataSourceInitializerDetector,\
173173
org.springframework.boot.autoconfigure.jdbc.DataSourceInitializationDataSourceInitializerDetector
174-

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
import org.springframework.boot.autoconfigure.AutoConfigurations;
4444
import org.springframework.boot.jdbc.DatabaseDriver;
4545
import org.springframework.boot.jdbc.EmbeddedDatabaseConnection;
46-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitialization;
46+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitialization;
4747
import org.springframework.boot.test.context.FilteredClassLoader;
4848
import org.springframework.boot.test.context.assertj.AssertableApplicationContext;
4949
import org.springframework.boot.test.context.runner.ApplicationContextRunner;

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
import org.springframework.boot.autoconfigure.orm.jpa.mapping.NonAnnotatedEntity;
6060
import org.springframework.boot.autoconfigure.orm.jpa.test.City;
6161
import org.springframework.boot.autoconfigure.transaction.jta.JtaAutoConfiguration;
62-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitialization;
62+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitialization;
6363
import org.springframework.boot.orm.jpa.hibernate.SpringImplicitNamingStrategy;
6464
import org.springframework.boot.orm.jpa.hibernate.SpringJtaPlatform;
6565
import org.springframework.boot.orm.jpa.hibernate.SpringPhysicalNamingStrategy;

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/flyway/FlywayDataSourceInitializerDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121

2222
import org.flywaydb.core.Flyway;
2323

24-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDataSourceInitializerDetector;
25-
import org.springframework.boot.jdbc.init.DataSourceInitializerDetector;
24+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDataSourceInitializerDetector;
25+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializerDetector;
2626

2727
/**
2828
* A {@link DataSourceInitializerDetector} for {@link Flyway}.

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/SpringJdbcDependsOnDataSourceInitializationDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
import java.util.HashSet;
2121
import java.util.Set;
2222

23-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDependsOnDataSourceInitializationDetector;
24-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitializationDetector;
23+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDependsOnDataSourceInitializationDetector;
24+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitializationDetector;
2525
import org.springframework.jdbc.core.JdbcOperations;
2626
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcOperations;
2727

Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.util.Collections;
2020
import java.util.Set;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.util.Collections;
2020
import java.util.Set;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.util.HashSet;
2020
import java.util.Set;

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/init/BeansOfTypeDetector.java renamed to spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/init/dependency/BeansOfTypeDetector.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.util.Arrays;
2020
import java.util.HashSet;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.util.Collection;
2020
import java.util.Collections;
+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.util.Set;
2020

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.lang.annotation.Documented;
2020
import java.lang.annotation.ElementType;
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.util.Set;
2020

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/init/package-info.java renamed to spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/init/dependency/package-info.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
*/
1616

1717
/**
18-
* General infrastructure for {@code DataSource} initialization.
18+
* Infrastructure for establishing {@code DataSource} initialization bean dependencies.
1919
*/
20-
package org.springframework.boot.jdbc.init;
20+
package org.springframework.boot.jdbc.init.dependency;

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jooq/JooqDependsOnDataSourceInitializationDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121

2222
import org.jooq.DSLContext;
2323

24-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDependsOnDataSourceInitializationDetector;
25-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitializationDetector;
24+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDependsOnDataSourceInitializationDetector;
25+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitializationDetector;
2626

2727
/**
2828
* {@link DependsOnDataSourceInitializationDetector} for jOOQ.

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/liquibase/LiquibaseDataSourceInitializerDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121

2222
import liquibase.integration.spring.SpringLiquibase;
2323

24-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDataSourceInitializerDetector;
25-
import org.springframework.boot.jdbc.init.DataSourceInitializerDetector;
24+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDataSourceInitializerDetector;
25+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializerDetector;
2626

2727
/**
2828
* A {@link DataSourceInitializerDetector} for Liquibase.

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/orm/jpa/JpaDataSourceInitializerDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525

2626
import org.springframework.beans.factory.config.BeanDefinition;
2727
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
28-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDataSourceInitializerDetector;
29-
import org.springframework.boot.jdbc.init.DataSourceInitializerDetector;
28+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDataSourceInitializerDetector;
29+
import org.springframework.boot.jdbc.init.dependency.DataSourceInitializerDetector;
3030
import org.springframework.core.env.Environment;
3131
import org.springframework.util.StringUtils;
3232

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/orm/jpa/JpaDependsOnDataSourceInitializationDetector.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
import javax.persistence.EntityManagerFactory;
2525

26-
import org.springframework.boot.jdbc.init.AbstractBeansOfTypeDependsOnDataSourceInitializationDetector;
27-
import org.springframework.boot.jdbc.init.DependsOnDataSourceInitializationDetector;
26+
import org.springframework.boot.jdbc.init.dependency.AbstractBeansOfTypeDependsOnDataSourceInitializationDetector;
27+
import org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitializationDetector;
2828
import org.springframework.core.env.Environment;
2929
import org.springframework.orm.jpa.AbstractEntityManagerFactoryBean;
3030

spring-boot-project/spring-boot/src/main/resources/META-INF/spring.factories

+4-4
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,14 @@ org.springframework.boot.diagnostics.FailureAnalysisReporter=\
8080
org.springframework.boot.diagnostics.LoggingFailureAnalysisReporter
8181

8282
# DataSource Initializer Detectors
83-
org.springframework.boot.jdbc.init.DataSourceInitializerDetector=\
83+
org.springframework.boot.jdbc.init.dependency.DataSourceInitializerDetector=\
8484
org.springframework.boot.flyway.FlywayDataSourceInitializerDetector,\
8585
org.springframework.boot.liquibase.LiquibaseDataSourceInitializerDetector,\
8686
org.springframework.boot.orm.jpa.JpaDataSourceInitializerDetector
8787

8888
# Depends On DataSource Initialization Detectors
89-
org.springframework.boot.jdbc.init.DependsOnDataSourceInitializationDetector=\
90-
org.springframework.boot.jdbc.init.AnnotationDependsOnDataSourceInitializationDetector,\
89+
org.springframework.boot.jdbc.init.dependency.DependsOnDataSourceInitializationDetector=\
90+
org.springframework.boot.jdbc.init.dependency.AnnotationDependsOnDataSourceInitializationDetector,\
9191
org.springframework.boot.jdbc.SpringJdbcDependsOnDataSourceInitializationDetector,\
9292
org.springframework.boot.jooq.JooqDependsOnDataSourceInitializationDetector,\
93-
org.springframework.boot.orm.jpa.JpaDependsOnDataSourceInitializationDetector
93+
org.springframework.boot.orm.jpa.JpaDependsOnDataSourceInitializationDetector
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.boot.jdbc.init;
17+
package org.springframework.boot.jdbc.init.dependency;
1818

1919
import java.io.File;
2020
import java.io.FileWriter;

0 commit comments

Comments
 (0)