Skip to content

Update description of the logger-name hint #14456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philwebb opened this issue Sep 13, 2018 · 5 comments
Closed

Update description of the logger-name hint #14456

philwebb opened this issue Sep 13, 2018 · 5 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@philwebb
Copy link
Member

Logging groups are currently configured using logging.level.<group>. Although nice and simple, It's possible that the group name could clash with an existing logger. We should review if a distinct namespace might work better.

One idea would be:

logging.group.<name>.level=...
logging.group.<name>.loggers=...

Unfortunately it's hard to get good meta-data for that.

Another option would be:

logging.group.level.<name>=...
logging.group.logger.<name>=...

That, feels a little backward.

@philwebb
Copy link
Member Author

There are also some IDE considerations to take into account. Existing auto-completion will not account for our provided names or those defined by the user.

@philwebb philwebb modified the milestones: 2.0.x, 2.1.x Sep 13, 2018
@philwebb philwebb added type: task A general task for: team-attention An issue we'd like other members of the team to review labels Sep 13, 2018
@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Sep 19, 2018
@snicoll
Copy link
Member

snicoll commented Sep 19, 2018

We've discussed this and the current situation is OK. We do have an explicit logger-name hint already so we should update the semantic of the hint to account for the group and let IDE developers know.

@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed type: task A general task labels Sep 23, 2018
@philwebb philwebb removed this from the 2.1.x milestone Sep 23, 2018
@snicoll snicoll reopened this Sep 23, 2018
@snicoll
Copy link
Member

snicoll commented Sep 23, 2018

I'd like to update the doc for logger-name as part of of this issue and create the relevant issues for the IDE support.

@snicoll snicoll added type: documentation A documentation update and removed status: declined A suggestion or change that we don't feel we should currently apply labels Sep 23, 2018
@snicoll snicoll self-assigned this Sep 23, 2018
@snicoll snicoll added this to the 2.1.x milestone Sep 23, 2018
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply type: task A general task type: documentation A documentation update and removed type: documentation A documentation update status: declined A suggestion or change that we don't feel we should currently apply type: task A general task labels Sep 23, 2018
@snicoll snicoll changed the title Consider if logging group clashes will cause an issue Update description of the logger-name hint Sep 23, 2018
@snicoll snicoll modified the milestones: 2.1.x, 2.1.0.RC1 Oct 2, 2018
@snicoll snicoll closed this as completed in 7bf3229 Oct 2, 2018
@snicoll
Copy link
Member

snicoll commented Oct 2, 2018

The issue for IntelliJ IDEA is here and the one for STS here.

@snicoll
Copy link
Member

snicoll commented Oct 10, 2018

I forgot that there is a dedicated section to update as well

@snicoll snicoll reopened this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants