Skip to content

Let Hibernate detect the dialect to use #16172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snicoll opened this issue Mar 8, 2019 · 5 comments
Closed

Let Hibernate detect the dialect to use #16172

snicoll opened this issue Mar 8, 2019 · 5 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Mar 8, 2019

Spring Boot detects the dialect to use based on the DataSource. Unfortunately, the defaults in framework are quite conservative and Hibernate is doing a good job at detecting the right dialect anyway.

As suggested in #15342 (comment) we should stop doing that upfront and let Hibernate do its thing.

@viktoriya-kutsarova
Copy link
Contributor

@snicoll If this issue is suitable for contribution, I can try to tackle it.

@snicoll
Copy link
Member Author

snicoll commented Mar 27, 2019

Thanks for the offer. The issue is assigned and therefore not opened for contribution. I've assigned myself as there are quite a lot of things to consider.

@trajano

This comment has been minimized.

@snicoll

This comment has been minimized.

@trajano
Copy link

trajano commented Aug 13, 2019

No I just noticed it now. Since this was closed about 4 months ago I thought it would've been here by now.

Anyway for those who are still stuck on the older version in case they reach here my workaround was

@Component
@Primary
public class CustomHibernateJpaVendorAdapter extends HibernateJpaVendorAdapter {

    @Override
    protected Class<?> determineDatabaseDialectClass(Database database) {
        return null;
    }

}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants