Skip to content

Consistently use type variant of AbstractDependsOnBeanFactoryPostProcessor dependsOn #17888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbhave opened this issue Aug 17, 2019 · 5 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: bug A general bug

Comments

@mbhave
Copy link
Contributor

mbhave commented Aug 17, 2019

#17805 and #16627 switched to using the type variant for mongo and liquibase.

Potential usages which could be switched are

flyway
cacheManager
quartzDataSourceInitializer

@mbhave mbhave added the type: bug A general bug label Aug 17, 2019
@mbhave mbhave added this to the 2.1.x milestone Aug 17, 2019
@snicoll
Copy link
Member

snicoll commented Aug 18, 2019

@mbhave is there a reason this is backported to 2.1.x? I can't help to feel a bit nervous to replace dependency by name to dependency by type in a maintenance release.

@wilkinsona
Copy link
Member

wilkinsona commented Aug 19, 2019

FWIW, I think the fix should be made in 2.1.x as it's addressing the same sort of problems as were reported in #17805 and #16627. We categorised both of those as bugs and fixed both of them in 2.1.x.

@mbhave
Copy link
Contributor Author

mbhave commented Aug 19, 2019

Yeah what @wilkinsona said was my reasoning for putting it in 2.1.x

@wilkinsona
Copy link
Member

wilkinsona commented Sep 3, 2019

cacheManager does not appear to be affected as CacheAutoConfiguration will back off if a custom CacheManager bean is defined. When it backs off it will take CacheManagerJpaDependencyConfiguration with it. While this avoids the named-based dependency problem, it creates a different problem as defining a custom CacheManager stops the entity manager factory bean from being configured to depend upon it. I've opened #18107.

@wilkinsona
Copy link
Member

quartzDataSourceInitializer has been addressed in #17539.

@wilkinsona wilkinsona removed this from the 2.1.x milestone Sep 3, 2019
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants