Skip to content

Document that a reactive transaction manager is not auto-configured with Spring Data Neo4j #23629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hantsy opened this issue Oct 11, 2020 · 4 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@hantsy
Copy link

hantsy commented Oct 11, 2020

I am trying to update the former SDN Rx example project to the latest Spring Boot 2.4(SDN RX is merged right ?).

The first problem is I have to configure a ReactiveTransactionManager to make it run.

	@Bean
	public ReactiveTransactionManager reactiveTransactionManager(Driver driver) {
		return  new ReactiveNeo4jTransactionManager(driver);
	}

I am not sure why we have to configure a transaction manager for Neo4j.

If it is a must in the new infrastructure, it should be autoconfigured.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 11, 2020
@snicoll
Copy link
Member

snicoll commented Oct 11, 2020

@hantsy please read the release notes before opening an issue.

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4.0-M2-Release-Notes#neo4j-1

@snicoll snicoll closed this as completed Oct 11, 2020
@snicoll snicoll added status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 11, 2020
@snicoll
Copy link
Member

snicoll commented Oct 11, 2020

Let's reuse this issue to add a note in the reference guide as what we thought was temporary is likely to stay in the 2.4.x line at least.

@snicoll snicoll reopened this Oct 11, 2020
@snicoll snicoll added type: documentation A documentation update and removed status: invalid An issue that we don't feel is valid labels Oct 11, 2020
@snicoll snicoll added this to the 2.4.x milestone Oct 11, 2020
@snicoll snicoll changed the title Spring Data Neo4j requires a transaction manager Document that a reactive transaction manager is not auto-configured with Spring Data Neo4j Oct 11, 2020
@hantsy
Copy link
Author

hantsy commented Oct 11, 2020

@snicoll Thanks for providing the link, it clarified my confusion.
But now TransactionManager became a must, in the pre versions, I remember it was optional.

@snicoll
Copy link
Member

snicoll commented Oct 11, 2020

I can't comment on whatever has been done outside of Spring Boot. Please reach out to the Spring Data Neo4j team.

@snicoll snicoll modified the milestones: 2.4.x, 2.4.0-M4 Oct 14, 2020
@snicoll snicoll self-assigned this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants