Skip to content

possibility to disable event propagation #24878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GreenRover opened this issue Jan 18, 2021 · 2 comments
Closed

possibility to disable event propagation #24878

GreenRover opened this issue Jan 18, 2021 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@GreenRover
Copy link

GreenRover commented Jan 18, 2021

a possibility to disable event propagation,

this is required to fix the broken "readiness" event propagation of SpringCloudStream.
For further Information see:
spring-cloud/spring-cloud-stream#2083

@wilkinsona You closed the PR #24865 would your prefer argumenst like:
--spring.boot.application.event.supress=context-prepared,started,running

those i would apply in:

private SpringApplicationRunListeners getRunListeners(String[] args) {

and take those affect in:
https://github.com/spring-projects/spring-boot/blob/6254ad634ecb0dc73034038f82fcde75fb99117a/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/SpringApplicationRunListeners.java

@philwebb you wrote "offer some kind of SpringFactoriesFilter " in: spring-cloud/spring-cloud-stream#2083 (comment)
Can you explain some more, sorry i dont understand what you mean.

Best regards Heiko

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 18, 2021
@snicoll
Copy link
Member

snicoll commented Jan 19, 2021

@GreenRover as Andy mentioned in the PR that he closed, we'd like to continue the discussion on the Spring Cloud Stream issue and then follow-up here if need to be. There is no need to have this conversation in two different places.

@snicoll snicoll closed this as completed Jan 19, 2021
@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged label Jan 19, 2021
@wilkinsona
Copy link
Member

To be fair to @GreenRover, Phil did say "feel free to open an issue". However I'd still prefer that we keep this discussion in the SCS tracker for now at least. @spencergibb has suggested that the config data API could be used and this would solve the problem in Spring Cloud Stream without requiring any changes in Boot. IMO, that's preferable as it avoids some unnecessary complexity in Boot.

Before anyone opens any more Boot issues, let us reach a conclusion in spring-cloud/spring-cloud-stream#2083 so that we know what, if anything, the issue needs to track.

@philwebb philwebb added for: team-meeting An issue we'd like to discuss as a team to make progress status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-meeting An issue we'd like to discuss as a team to make progress labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

5 participants