Skip to content

Use consistent asciidoctor subs attribute #25101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Feb 4, 2021 · 4 comments
Closed

Use consistent asciidoctor subs attribute #25101

philwebb opened this issue Feb 4, 2021 · 4 comments
Labels
type: task A general task
Milestone
2.5.0

Comments

@philwebb
Copy link
Member

philwebb commented Feb 4, 2021

Our source blocks currently have a mix of different subs, with many not defining them at all. We should try to be consistent.
@philwebb philwebb added this to the 2.5.x milestone Feb 4, 2021
@philwebb philwebb added the type: task A general task label Feb 4, 2021
@robert-smith-911
Copy link
Contributor

Just curious @philwebb , what do you mean by subs?

@philwebb
Copy link
Member Author

philwebb commented Apr 6, 2021

@robert-smith-911

We have a few imports that declare them:

[source,java,indent=0,subs="verbatim,quotes,attributes"]
----
include::{code-examples}/context/embedded/TomcatServerCustomizerExample.java[tag=configuration]
----

And a lot more that don't

@robert-smith-911
Copy link
Contributor

@philwebb Something I can look at?

@philwebb
Copy link
Member Author

philwebb commented Apr 6, 2021

Thanks for the offer, but it's probably best if we tackle as part of #6313

@philwebb philwebb modified the milestones: 2.5.x, 2.5.0 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@philwebb @robert-smith-911