Skip to content

Deprecate our Gradle plugin's integration with Gradle's maven plugin #25267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreis2211 opened this issue Feb 13, 2021 · 5 comments
Closed

Deprecate our Gradle plugin's integration with Gradle's maven plugin #25267

dreis2211 opened this issue Feb 13, 2021 · 5 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@dreis2211
Copy link
Contributor

Hi,

this is sort of related to #24225 but given the impact I think it's worth a dedicated ticket.

The maven plugin is deprecated since 6.x and Boot's Gradle Plugin makes use of it via MavenPluginAction...Since the documentation is also kind of "advertising" the usage (it's the first option in the docs) I'm relatively certain that users still use the maven plugin instead of the maven publish plugin. Maybe we could put a little warning in the docs about the deprecation (in earlier Boot releases) or remove the docs completely?

Anyhow - if the plan is to support Gradle 7 this will break the Gradle Plugin as it removed classes like MavenPlugin.

In case you wanted to tackle this inside #24225 please ignore me and close the ticket, but when I thought about release notes generation a dedicated ticket made sense in my head.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 13, 2021
@wilkinsona
Copy link
Member

Thanks, @dreis2211. The plugin already works with Gradle 7 despite the absence of the MavenPlugin class due to #24526. We're testing that against 7.0-milestone-1 at the moment. There's still some things to do here, though, and I think we should take a staged approach to this one:

  1. Update the documentation to favour the Maven Publish plugin. We can do this in 2.3.x.
  2. Deprecate support for the Maven plugin. We can probably do this in 2.5 if we also drop support for Gradle 5 as proposed in Raise the minimum supported version of Gradle to 6.x #24225
  3. Remove support for the Maven plugin. We can do this in 2.7 or when we drop support for Gradle 6 if that happens earlier.

@dreis2211
Copy link
Contributor Author

Ah, I missed #24526 - learned something new. Thanks.

@wilkinsona
Copy link
Member

I've opened #25275 to improve the documentation in 2.3.x. Let's use this issue for the deprecation in 2.5. Stage three will then be taken care of as part of our standard deprecation removal sweep in 2.7.

@wilkinsona wilkinsona changed the title Remove legacy maven plugin in spring-boot-gradle-plugin Deprecate our Gradle plugin's integration with Gradle's maven plugin Feb 14, 2021
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 14, 2021
@wilkinsona wilkinsona added this to the 2.5.x milestone Feb 14, 2021
@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Feb 14, 2021
@wilkinsona
Copy link
Member

wilkinsona commented Feb 14, 2021

I've labelled this as on hold as we should only do it if #24225 makes it into 2.5.

@wilkinsona
Copy link
Member

On second thought, I don't think we need to wait. We should be discouraging the use of the maven plugin as much as we can at this point.

@wilkinsona wilkinsona removed the status: on-hold We can't start working on this issue yet label Feb 19, 2021
@wilkinsona wilkinsona self-assigned this Feb 19, 2021
@snicoll snicoll modified the milestones: 2.5.x, 2.5.0-M3 Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants