Skip to content

WebMvcTags to ServerRequestObservationConvention migration #33673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janchristian-haddorp opened this issue Jan 3, 2023 · 1 comment
Closed
Labels
for: external-project For an external project and not something we can fix status: invalid An issue that we don't feel is valid

Comments

@janchristian-haddorp
Copy link

Starting with Spring Boot 3.0.0 the class WebMvcTags is deprecated and should be replaced by DefaultServerRequestObservationConvention.

WebMvcTags containts specials mapping logic for Spring Data REST.

private static String getMatchingPattern(HttpServletRequest request) {
    PathPattern dataRestPathPattern = (PathPattern) request.getAttribute(DATA_REST_PATH_PATTERN_ATTRIBUTE);
    if (dataRestPathPattern != null) {
        return dataRestPathPattern.getPatternString();
    }
    return (String) request.getAttribute(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE);
}

This functionality is missing on DefaultServerRequestObservationConvention. Will there be a full featured replacement?

@bclozel
Copy link
Member

bclozel commented Jan 3, 2023

I've just reported this issue to spring-data-rest with the relevant information, see spring-projects/spring-data-rest#2212.
I'm closing this one has this needs to be addressed in data REST directly. Thanks for letting us know!

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2023
@bclozel bclozel added status: invalid An issue that we don't feel is valid for: external-project For an external project and not something we can fix and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

3 participants