Skip to content

Allow use of multiple additional-spring-configuration-metadata.json #34210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpalmmna opened this issue Feb 15, 2023 · 3 comments
Closed

Allow use of multiple additional-spring-configuration-metadata.json #34210

dpalmmna opened this issue Feb 15, 2023 · 3 comments
Labels
status: duplicate A duplicate of another issue

Comments

@dpalmmna
Copy link

dpalmmna commented Feb 15, 2023

Allow the posibility to configure multiple additional-spring-configuration-metadata.json files. Need arises when having to use hint values defined in dependencies.
When having to import hints from multiple dependencies it could be allowed to use multiple additional-spring-configuration-metadata files found with patter additional-spring-configuration-metadata*.json.

Or allow annotation to provide hint values in java code.

Or if better solution please advise.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 15, 2023
@wilkinsona
Copy link
Member

wilkinsona commented Feb 15, 2023

I am struggling to imagine a situation where a dependency would have an additional-spring-configuration-metadata.json file that would be of interest to a consumer. Any hints from the dependency's additional metadata should have been merged into its spring-configuration-metadata.json file at compilation time. In other words, consumers should only be interested in spring-configuration-metadata.json files.

Can you please explain your requirement in a bit more detail so that we can understand the purpose of the multiple additional-spring-configuration-metadata.json files? A concrete example pushed to GitHub or zipped up and attached to this issue would also be useful.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Feb 15, 2023
@dpalmmna
Copy link
Author

test-spring.zip
Following test case as example the generated metadata for module2 does not contain all hints

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 16, 2023
@wilkinsona
Copy link
Member

Thank you. I now understand what you're trying to do and it looks to me like an attempt to address #18366. While supporting multiple additional-spring-configuration-metadata.json files may meet your needs, I'm not sure that it will work for everyone. I'll add a note to #18366 to consider it as an option. I'm going to close this issue as a duplicate as we don't want to make any changes until we've had to time to consider all sides of the problem.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2023
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 21, 2023
@wilkinsona wilkinsona changed the title [spring-boot-configuration-processor] Allow use of multiple additional-spring-configuration-metadata.json Allow use of multiple additional-spring-configuration-metadata.json Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants