Skip to content

AbstractJpaAutoConfigurationTests imports internal infra of DataSourceAutoConfiguration #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Jun 22, 2017 · 0 comments
Closed

AbstractJpaAutoConfigurationTests imports internal infra of DataSourceAutoConfiguration #9579

snicoll opened this issue Jun 22, 2017 · 0 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.0.0.M3

Comments

@snicoll
Copy link
Member

snicoll commented Jun 22, 2017 •
edited
Loading

While working on #9528, I've noticed that AbstractJpaAutoConfigurationTests imports EmbeddedDataSourceConfiguration and DataSourceAutoConfiguration, the latter is managed and imported by the former depending on certain conditions matching.

Also, those tests are not really working in isolation and are reusing the same database. They currently work with side effect (or create-drop semantic) probably so we should make sure that each test uses a separate database.
@snicoll snicoll added this to the 2.0.0.M3 milestone Jun 22, 2017
@snicoll snicoll self-assigned this Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.0.0.M3
Development

No branches or pull requests
1 participant
@snicoll