From 19298a79e42172bc6386f6e9de450daaed3db92d Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Fri, 3 Aug 2018 08:35:45 +0900 Subject: [PATCH] Return null immediately when sla is null in convertSla() See https://github.com/micrometer-metrics/micrometer/pull/746 --- .../autoconfigure/metrics/PropertiesMeterFilter.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/PropertiesMeterFilter.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/PropertiesMeterFilter.java index 9120968d2c3a..eacbe66e893f 100644 --- a/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/PropertiesMeterFilter.java +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/PropertiesMeterFilter.java @@ -43,8 +43,6 @@ */ public class PropertiesMeterFilter implements MeterFilter { - private static final ServiceLevelAgreementBoundary[] EMPTY_SLA = {}; - private final MetricsProperties properties; private final MeterFilter mapFilter; @@ -90,7 +88,10 @@ public DistributionStatisticConfig configure(Meter.Id id, } private long[] convertSla(Meter.Type meterType, ServiceLevelAgreementBoundary[] sla) { - long[] converted = Arrays.stream((sla != null) ? sla : EMPTY_SLA) + if (sla == null) { + return null; + } + long[] converted = Arrays.stream(sla) .map((candidate) -> candidate.getValue(meterType)) .filter(Objects::nonNull).mapToLong(Long::longValue).toArray(); return (converted.length != 0) ? converted : null;