Skip to content

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 22, 2019

see gh-15986

Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 22, 2019
@nosan nosan force-pushed the gh-15986 branch 3 times, most recently from 8c95649 to a001e28 Compare February 22, 2019 12:35
@nosan nosan changed the title web and sql groups are being expanded to the logger names that each represents web and sql groups must be expanded to the logger names that each represents Feb 22, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Feb 26, 2019
@wilkinsona wilkinsona added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 26, 2019
@snicoll snicoll self-assigned this Feb 27, 2019
@snicoll snicoll changed the title web and sql groups must be expanded to the logger names that each represents Debug mode is not logging web and sql related loggers Feb 27, 2019
snicoll added a commit that referenced this pull request Feb 27, 2019
* pr/16018:
  Polish "Debug mode is not logging web and sql related loggers"
  Debug mode is not logging web and sql related loggers
@snicoll snicoll modified the milestones: 2.1.x, 2.1.4 Feb 27, 2019
@snicoll snicoll closed this in 978f801 Feb 27, 2019
@snicoll
Copy link
Member

snicoll commented Feb 27, 2019

Thank you again @nosan. I've merged your contribution to 2.1.x and master with a polish commit as I didn't like the use of Optional.

@nosan nosan deleted the gh-15986 branch February 27, 2019 12:54
@nosan
Copy link
Contributor Author

nosan commented Feb 27, 2019

@snicoll Thanks, you are right. Optional is not necessary here at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: regression A regression from a previous release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants