From 6d8dc491b2c751b4ceb4ce3ba180eb17ffa02990 Mon Sep 17 00:00:00 2001 From: Ben Gilbert Date: Tue, 16 May 2023 14:58:12 +0100 Subject: [PATCH] Restore executeInTransaction to default true FlywayProperties has executeInTransaction default as false, changing the org.flywaydb.core.api.configuration.Configuration#isExecuteInTransaction default. See also org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration.FlywayConfiguration#configureProperties --- .../boot/autoconfigure/flyway/FlywayProperties.java | 2 +- .../boot/autoconfigure/flyway/FlywayPropertiesTests.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayProperties.java b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayProperties.java index a783355be91b..e6c73a175f60 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayProperties.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayProperties.java @@ -365,7 +365,7 @@ public class FlywayProperties { /** * Whether Flyway should execute SQL within a transaction. */ - private boolean executeInTransaction; + private boolean executeInTransaction = true; public boolean isEnabled() { return this.enabled; diff --git a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayPropertiesTests.java b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayPropertiesTests.java index ecefacf2aee3..e8adc2b0133d 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayPropertiesTests.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/flyway/FlywayPropertiesTests.java @@ -92,6 +92,7 @@ void defaultValuesAreConsistent() { assertThat(properties.getPlaceholderSeparator()).isEqualTo(configuration.getPlaceholderSeparator()); assertThat(properties.getScriptPlaceholderPrefix()).isEqualTo(configuration.getScriptPlaceholderPrefix()); assertThat(properties.getScriptPlaceholderSuffix()).isEqualTo(configuration.getScriptPlaceholderSuffix()); + assertThat(properties.isExecuteInTransaction()).isEqualTo(configuration.isExecuteInTransaction()); } @Test