Skip to content

Commit 8b006ab

Browse files
committed
#2 - Create relational and r2dbc packages.
Move types into relational and r2dbc packages in preparation for a later module separation.
1 parent cee7479 commit 8b006ab

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+212
-158
lines changed

src/main/java/org/springframework/data/jdbc/core/function/ConnectionAccessor.java renamed to src/main/java/org/springframework/data/r2dbc/function/ConnectionAccessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.Connection;
1919
import reactor.core.publisher.Flux;

src/main/java/org/springframework/data/jdbc/core/function/DatabaseClient.java renamed to src/main/java/org/springframework/data/r2dbc/function/DatabaseClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.ConnectionFactory;
1919
import io.r2dbc.spi.Row;

src/main/java/org/springframework/data/jdbc/core/function/DefaultDatabaseClient.java renamed to src/main/java/org/springframework/data/r2dbc/function/DefaultDatabaseClient.java

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.Connection;
1919
import io.r2dbc.spi.ConnectionFactory;
@@ -53,7 +53,8 @@
5353
import org.springframework.data.domain.Sort;
5454
import org.springframework.data.domain.Sort.NullHandling;
5555
import org.springframework.data.domain.Sort.Order;
56-
import org.springframework.data.jdbc.core.function.connectionfactory.ConnectionProxy;
56+
import org.springframework.data.r2dbc.function.connectionfactory.ConnectionProxy;
57+
import org.springframework.data.r2dbc.function.convert.ColumnMapRowMapper;
5758
import org.springframework.data.util.Pair;
5859
import org.springframework.jdbc.core.SqlProvider;
5960
import org.springframework.jdbc.support.SQLExceptionTranslator;
@@ -240,7 +241,7 @@ private static void doBind(Statement statement, Map<String, Optional<Object>> by
240241
}
241242

242243
/**
243-
* Default {@link org.springframework.data.jdbc.core.function.DatabaseClient.SqlSpec} implementation.
244+
* Default {@link DatabaseClient.SqlSpec} implementation.
244245
*/
245246
private class DefaultSqlSpec implements SqlSpec {
246247

@@ -261,8 +262,7 @@ public GenericExecuteSpec sql(Supplier<String> sqlSupplier) {
261262
}
262263

263264
/**
264-
* Base class for {@link org.springframework.data.jdbc.core.function.DatabaseClient.GenericExecuteSpec}
265-
* implementations.
265+
* Base class for {@link DatabaseClient.GenericExecuteSpec} implementations.
266266
*/
267267
@RequiredArgsConstructor
268268
private class GenericExecuteSpecSupport {
@@ -358,7 +358,7 @@ public GenericExecuteSpecSupport bind(Object bean) {
358358
}
359359

360360
/**
361-
* Default {@link org.springframework.data.jdbc.core.function.DatabaseClient.GenericExecuteSpec} implementation.
361+
* Default {@link DatabaseClient.GenericExecuteSpec} implementation.
362362
*/
363363
private class DefaultGenericExecuteSpec extends GenericExecuteSpecSupport implements GenericExecuteSpec {
364364

@@ -422,7 +422,7 @@ protected GenericExecuteSpecSupport createInstance(Map<Integer, Optional<Object>
422422
}
423423

424424
/**
425-
* Default {@link org.springframework.data.jdbc.core.function.DatabaseClient.GenericExecuteSpec} implementation.
425+
* Default {@link DatabaseClient.GenericExecuteSpec} implementation.
426426
*/
427427
@SuppressWarnings("unchecked")
428428
private class DefaultTypedGenericExecuteSpec<T> extends GenericExecuteSpecSupport implements TypedExecuteSpec<T> {
@@ -490,7 +490,7 @@ protected DefaultTypedGenericExecuteSpec<T> createInstance(Map<Integer, Optional
490490
}
491491

492492
/**
493-
* Default {@link org.springframework.data.jdbc.core.function.DatabaseClient.SelectFromSpec} implementation.
493+
* Default {@link DatabaseClient.SelectFromSpec} implementation.
494494
*/
495495
class DefaultSelectFromSpec implements SelectFromSpec {
496496

@@ -506,8 +506,7 @@ public <T> TypedSelectSpec<T> from(Class<T> table) {
506506
}
507507

508508
/**
509-
* Base class for {@link org.springframework.data.jdbc.core.function.DatabaseClient.GenericExecuteSpec}
510-
* implementations.
509+
* Base class for {@link DatabaseClient.GenericExecuteSpec} implementations.
511510
*/
512511
@RequiredArgsConstructor
513512
private abstract class DefaultSelectSpecSupport {
@@ -678,7 +677,7 @@ protected DefaultGenericSelectSpec createInstance(String table, List<String> pro
678677
}
679678

680679
/**
681-
* Default implementation of {@link org.springframework.data.jdbc.core.function.DatabaseClient.TypedInsertSpec}.
680+
* Default implementation of {@link DatabaseClient.TypedInsertSpec}.
682681
*/
683682
@SuppressWarnings("unchecked")
684683
private class DefaultTypedSelectSpec<T> extends DefaultSelectSpecSupport implements TypedSelectSpec<T> {
@@ -779,7 +778,7 @@ protected DefaultTypedSelectSpec<T> createInstance(String table, List<String> pr
779778
}
780779

781780
/**
782-
* Default {@link org.springframework.data.jdbc.core.function.DatabaseClient.InsertIntoSpec} implementation.
781+
* Default {@link DatabaseClient.InsertIntoSpec} implementation.
783782
*/
784783
class DefaultInsertIntoSpec implements InsertIntoSpec {
785784

@@ -795,7 +794,7 @@ public <T> TypedInsertSpec<T> into(Class<T> table) {
795794
}
796795

797796
/**
798-
* Default implementation of {@link org.springframework.data.jdbc.core.function.DatabaseClient.GenericInsertSpec}.
797+
* Default implementation of {@link DatabaseClient.GenericInsertSpec}.
799798
*/
800799
@RequiredArgsConstructor
801800
class DefaultGenericInsertSpec implements GenericInsertSpec {
@@ -891,7 +890,7 @@ private void doBind(Statement statement) {
891890
}
892891

893892
/**
894-
* Default implementation of {@link org.springframework.data.jdbc.core.function.DatabaseClient.TypedInsertSpec}.
893+
* Default implementation of {@link DatabaseClient.TypedInsertSpec}.
895894
*/
896895
@RequiredArgsConstructor
897896
class DefaultTypedInsertSpec<T> implements TypedInsertSpec<T>, InsertSpec {

src/main/java/org/springframework/data/jdbc/core/function/DefaultDatabaseClientBuilder.java renamed to src/main/java/org/springframework/data/r2dbc/function/DefaultDatabaseClientBuilder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,18 @@
1414
* limitations under the License.
1515
*/
1616

17-
package org.springframework.data.jdbc.core.function;
17+
package org.springframework.data.r2dbc.function;
18+
19+
import io.r2dbc.spi.ConnectionFactory;
1820

1921
import java.util.function.Consumer;
2022

21-
import org.springframework.data.jdbc.core.function.DatabaseClient.Builder;
23+
import org.springframework.data.r2dbc.function.DatabaseClient.Builder;
2224
import org.springframework.jdbc.support.SQLErrorCodeSQLExceptionTranslator;
2325
import org.springframework.jdbc.support.SQLExceptionTranslator;
2426
import org.springframework.lang.Nullable;
2527
import org.springframework.util.Assert;
2628

27-
import io.r2dbc.spi.ConnectionFactory;
28-
2929
/**
3030
* Default implementation of {@link DatabaseClient.Builder}.
3131
*

src/main/java/org/springframework/data/jdbc/core/function/DefaultFetchSpec.java renamed to src/main/java/org/springframework/data/r2dbc/function/DefaultFetchSpec.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.Connection;
1919
import lombok.RequiredArgsConstructor;
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.Row;
1919
import io.r2dbc.spi.RowMetadata;
@@ -31,6 +31,7 @@
3131
import org.springframework.data.jdbc.core.mapping.JdbcPersistentEntity;
3232
import org.springframework.data.jdbc.core.mapping.JdbcPersistentProperty;
3333
import org.springframework.data.mapping.PersistentPropertyAccessor;
34+
import org.springframework.data.r2dbc.function.convert.EntityRowMapper;
3435
import org.springframework.data.util.Pair;
3536
import org.springframework.data.util.StreamUtils;
3637
import org.springframework.util.ClassUtils;

src/main/java/org/springframework/data/jdbc/core/function/DefaultSqlResult.java renamed to src/main/java/org/springframework/data/r2dbc/function/DefaultSqlResult.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.Connection;
1919
import io.r2dbc.spi.Result;

src/main/java/org/springframework/data/jdbc/core/function/FetchSpec.java renamed to src/main/java/org/springframework/data/r2dbc/function/FetchSpec.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import reactor.core.publisher.Flux;
1919
import reactor.core.publisher.Mono;

src/main/java/org/springframework/data/jdbc/core/function/ReactiveDataAccessStrategy.java renamed to src/main/java/org/springframework/data/r2dbc/function/ReactiveDataAccessStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.Row;
1919
import io.r2dbc.spi.RowMetadata;

src/main/java/org/springframework/data/jdbc/core/function/SqlResult.java renamed to src/main/java/org/springframework/data/r2dbc/function/SqlResult.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function;
1717

1818
import io.r2dbc.spi.Row;
1919
import io.r2dbc.spi.RowMetadata;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function.connectionfactory;
16+
package org.springframework.data.r2dbc.function.connectionfactory;
1717

1818
import io.r2dbc.spi.Connection;
1919

src/main/java/org/springframework/data/jdbc/core/function/ColumnMapRowMapper.java renamed to src/main/java/org/springframework/data/r2dbc/function/convert/ColumnMapRowMapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function.convert;
1717

1818
import io.r2dbc.spi.ColumnMetadata;
1919
import io.r2dbc.spi.Row;

src/main/java/org/springframework/data/jdbc/core/function/EntityRowMapper.java renamed to src/main/java/org/springframework/data/r2dbc/function/convert/EntityRowMapper.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function.convert;
1717

18+
import io.r2dbc.spi.Row;
19+
import io.r2dbc.spi.RowMetadata;
1820
import lombok.NonNull;
1921
import lombok.RequiredArgsConstructor;
2022

@@ -35,9 +37,6 @@
3537
import org.springframework.data.mapping.model.ParameterValueProvider;
3638
import org.springframework.util.ClassUtils;
3739

38-
import io.r2dbc.spi.Row;
39-
import io.r2dbc.spi.RowMetadata;
40-
4140
/**
4241
* Maps a {@link io.r2dbc.spi.Row} to an entity of type {@code T}, including entities referenced.
4342
*

src/main/java/org/springframework/data/jdbc/core/function/IterableUtils.java renamed to src/main/java/org/springframework/data/r2dbc/function/convert/IterableUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function.convert;
1717

1818
import java.util.ArrayList;
1919
import java.util.Collection;

src/main/java/org/springframework/data/jdbc/core/function/MappingR2dbcConverter.java renamed to src/main/java/org/springframework/data/r2dbc/function/convert/MappingR2dbcConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.core.function;
16+
package org.springframework.data.r2dbc.function.convert;
1717

1818
import io.r2dbc.spi.Row;
1919
import io.r2dbc.spi.RowMetadata;

src/main/java/org/springframework/data/jdbc/repository/R2dbcRepository.java renamed to src/main/java/org/springframework/data/r2dbc/repository/R2dbcRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.repository;
16+
package org.springframework.data.r2dbc.repository;
1717

1818
import org.springframework.data.repository.NoRepositoryBean;
1919
import org.springframework.data.repository.reactive.ReactiveCrudRepository;
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
/**
2+
* R2DBC-specific repository implementation.
3+
*/
4+
@NonNullApi
5+
package org.springframework.data.r2dbc.repository;
6+
7+
import org.springframework.lang.NonNullApi;

src/main/java/org/springframework/data/jdbc/repository/query/AbstractR2dbcQuery.java renamed to src/main/java/org/springframework/data/r2dbc/repository/query/AbstractR2dbcQuery.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,22 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.repository.query;
16+
package org.springframework.data.r2dbc.repository.query;
1717

1818
import reactor.core.publisher.Flux;
1919
import reactor.core.publisher.Mono;
2020

2121
import org.reactivestreams.Publisher;
2222
import org.springframework.core.convert.converter.Converter;
2323
import org.springframework.data.convert.EntityInstantiators;
24-
import org.springframework.data.jdbc.core.function.DatabaseClient;
25-
import org.springframework.data.jdbc.core.function.DatabaseClient.GenericExecuteSpec;
26-
import org.springframework.data.jdbc.core.function.FetchSpec;
27-
import org.springframework.data.jdbc.core.function.MappingR2dbcConverter;
28-
import org.springframework.data.jdbc.repository.query.R2dbcQueryExecution.ResultProcessingConverter;
29-
import org.springframework.data.jdbc.repository.query.R2dbcQueryExecution.ResultProcessingExecution;
24+
import org.springframework.data.r2dbc.function.DatabaseClient;
25+
import org.springframework.data.r2dbc.function.DatabaseClient.GenericExecuteSpec;
26+
import org.springframework.data.r2dbc.function.FetchSpec;
27+
import org.springframework.data.r2dbc.function.convert.MappingR2dbcConverter;
28+
import org.springframework.data.r2dbc.repository.query.R2dbcQueryExecution.ResultProcessingConverter;
29+
import org.springframework.data.r2dbc.repository.query.R2dbcQueryExecution.ResultProcessingExecution;
30+
import org.springframework.data.relational.repository.query.RelationalParameterAccessor;
31+
import org.springframework.data.relational.repository.query.RelationalParametersParameterAccessor;
3032
import org.springframework.data.repository.query.ParameterAccessor;
3133
import org.springframework.data.repository.query.RepositoryQuery;
3234
import org.springframework.data.repository.query.ResultProcessor;
@@ -79,7 +81,7 @@ public R2dbcQueryMethod getQueryMethod() {
7981
public Object execute(Object[] parameters) {
8082

8183
return method.hasReactiveWrapperParameter() ? executeDeferred(parameters)
82-
: execute(new JdbcParametersParameterAccessor(method, parameters));
84+
: execute(new RelationalParametersParameterAccessor(method, parameters));
8385
}
8486

8587
@SuppressWarnings("unchecked")
@@ -94,7 +96,7 @@ private Object executeDeferred(Object[] parameters) {
9496
return Mono.defer(() -> (Mono<Object>) execute(parameterAccessor));
9597
}
9698

97-
private Object execute(JdbcParameterAccessor parameterAccessor) {
99+
private Object execute(RelationalParameterAccessor parameterAccessor) {
98100

99101
// TODO: ConvertingParameterAccessor
100102
BindableQuery query = createQuery(parameterAccessor);
@@ -143,5 +145,5 @@ private R2dbcQueryExecution getExecutionToWrap() {
143145
* @param accessor must not be {@literal null}.
144146
* @return
145147
*/
146-
protected abstract BindableQuery createQuery(JdbcParameterAccessor accessor);
148+
protected abstract BindableQuery createQuery(RelationalParameterAccessor accessor);
147149
}

src/main/java/org/springframework/data/jdbc/repository/query/BindableQuery.java renamed to src/main/java/org/springframework/data/r2dbc/repository/query/BindableQuery.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,22 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.repository.query;
16+
package org.springframework.data.r2dbc.repository.query;
1717

1818
import java.util.function.Supplier;
1919

20-
import org.springframework.data.jdbc.core.function.DatabaseClient.BindSpec;
20+
import org.springframework.data.r2dbc.function.DatabaseClient.BindSpec;
2121

2222
/**
2323
* Interface declaring a query that supplies SQL and can bind parameters to a {@link BindSpec}.
24-
*
24+
*
2525
* @author Mark Paluch
2626
*/
2727
public interface BindableQuery extends Supplier<String> {
2828

2929
/**
3030
* Bind parameters to the {@link BindSpec query}.
31-
*
31+
*
3232
* @param bindSpec must not be {@literal null}.
3333
* @return the bound query object.
3434
*/

src/main/java/org/springframework/data/jdbc/repository/query/R2dbcParameterAccessor.java renamed to src/main/java/org/springframework/data/r2dbc/repository/query/R2dbcParameterAccessor.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.data.jdbc.repository.query;
16+
package org.springframework.data.r2dbc.repository.query;
1717

1818
import reactor.core.publisher.Flux;
1919
import reactor.core.publisher.Mono;
@@ -22,6 +22,7 @@
2222
import java.util.ArrayList;
2323
import java.util.List;
2424

25+
import org.springframework.data.relational.repository.query.RelationalParametersParameterAccessor;
2526
import org.springframework.data.repository.util.ReactiveWrapperConverters;
2627
import org.springframework.data.repository.util.ReactiveWrappers;
2728

@@ -31,7 +32,7 @@
3132
*
3233
* @author Mark Paluch
3334
*/
34-
class R2dbcParameterAccessor extends JdbcParametersParameterAccessor {
35+
class R2dbcParameterAccessor extends RelationalParametersParameterAccessor {
3536

3637
private final Object[] values;
3738
private final List<MonoProcessor<?>> subscriptions;

0 commit comments

Comments
 (0)