Skip to content

Commit bea9501

Browse files
schaudermp911de
authored andcommitted
#2 - Fixes and improves the Dependency test.
Now considers the new packages appropriately as well. consideres the `repository` package to be part of the sub-module `repository.reactive`.
1 parent 900918f commit bea9501

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/test/java/org/springframework/data/jdbc/degraph/DependencyTests.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
import static org.junit.Assert.*;
2020

2121
import de.schauderhaft.degraph.check.JCheck;
22+
import de.schauderhaft.degraph.configuration.NamedPattern;
2223
import scala.runtime.AbstractFunction1;
2324

24-
import org.junit.Ignore;
2525
import org.junit.Test;
2626

2727
/**
@@ -38,13 +38,14 @@ public void cycleFree() {
3838
classpath() //
3939
.noJars() //
4040
.including("org.springframework.data.jdbc.**") //
41+
.including("org.springframework.data.relational.**") //
42+
.including("org.springframework.data.r2dbc.**") //
4143
.filterClasspath("*target/classes") // exclude test code
42-
.printOnFailure("degraph.graphml"),
44+
.withSlicing("modules", "org.springframework.data.(*).**").printOnFailure("degraph.graphml"),
4345
JCheck.violationFree());
4446
}
4547

4648
@Test // DATAJDBC-220
47-
@Ignore("I don't understand why this fails after adding reactive repos - mp911de")
4849
public void acrossModules() {
4950

5051
assertThat( //
@@ -60,8 +61,11 @@ public Object apply(String s) { //
6061
}) // exclude test code
6162
.withSlicing("sub-modules", // sub-modules are defined by any of the following pattern.
6263
"org.springframework.data.jdbc.(**).*", //
64+
"org.springframework.data.relational.(**).*", //
65+
new NamedPattern("org.springframework.data.r2dbc.**", "repository.reactive"), //
6366
"org.springframework.data.(**).*") //
6467
.printTo("degraph-across-modules.graphml"), // writes a graphml to this location
6568
JCheck.violationFree());
6669
}
70+
6771
}

0 commit comments

Comments
 (0)