Skip to content

Commit ccb1c13

Browse files
committed
Use UTC timezone in Jackson builder and factory tests
Issue: SPR-12634
1 parent c7b324b commit ccb1c13

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilderTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
import com.fasterxml.jackson.datatype.joda.cfg.JacksonJodaDateFormat;
5959
import com.fasterxml.jackson.datatype.joda.ser.DateTimeSerializer;
6060
import org.joda.time.DateTime;
61+
import org.joda.time.DateTimeZone;
6162
import org.joda.time.format.DateTimeFormat;
6263
import org.junit.Test;
6364

@@ -223,16 +224,17 @@ public void setModules() {
223224
@Test
224225
public void defaultModules() throws JsonProcessingException, UnsupportedEncodingException {
225226
ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json().build();
226-
DateTime dateTime = DateTime.parse("2011-12-03T10:15:30");
227-
assertEquals("1322903730000", new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
227+
Long timestamp = 1322903730000L;
228+
DateTime dateTime = new DateTime(timestamp, DateTimeZone.UTC);
229+
assertEquals(timestamp.toString(), new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
228230
}
229231

230232
@Test // SPR-12634
231233
public void customizeDefaultModules() throws JsonProcessingException, UnsupportedEncodingException {
232234
ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json()
233235
.featuresToDisable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
234236
.modulesToInstall(CustomModule.class).build();
235-
DateTime dateTime = DateTime.parse("2011-12-03T10:15:30");
237+
DateTime dateTime = new DateTime(1322903730000L, DateTimeZone.UTC);
236238
assertEquals("\"2011-12-03\"", new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
237239
}
238240

@@ -241,7 +243,7 @@ public void customizeDefaultModulesWithSerializer() throws JsonProcessingExcepti
241243
ObjectMapper objectMapper = Jackson2ObjectMapperBuilder.json()
242244
.serializerByType(DateTime.class, new DateTimeSerializer(new JacksonJodaDateFormat(DateTimeFormat.forPattern("YYYY-MM-dd").withZoneUTC())))
243245
.featuresToDisable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS).build();
244-
DateTime dateTime = DateTime.parse("2011-12-03T10:15:30");
246+
DateTime dateTime = new DateTime(1322903730000L, DateTimeZone.UTC);
245247
assertEquals("\"2011-12-03\"", new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
246248
}
247249

spring-web/src/test/java/org/springframework/http/converter/json/Jackson2ObjectMapperFactoryBeanTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
import com.fasterxml.jackson.datatype.joda.cfg.JacksonJodaDateFormat;
5757
import com.fasterxml.jackson.datatype.joda.ser.DateTimeSerializer;
5858
import org.joda.time.DateTime;
59+
import org.joda.time.DateTimeZone;
5960
import org.joda.time.format.DateTimeFormat;
6061
import org.junit.Before;
6162
import org.junit.Test;
@@ -235,8 +236,9 @@ public void defaultModules() throws JsonProcessingException, UnsupportedEncoding
235236
this.factory.afterPropertiesSet();
236237
ObjectMapper objectMapper = this.factory.getObject();
237238

238-
DateTime dateTime = DateTime.parse("2011-12-03T10:15:30");
239-
assertEquals("1322903730000", new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
239+
Long timestamp = 1322903730000L;
240+
DateTime dateTime = new DateTime(timestamp, DateTimeZone.UTC);
241+
assertEquals(timestamp.toString(), new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
240242
}
241243

242244
@Test // SPR-12634
@@ -246,7 +248,7 @@ public void customizeDefaultModules() throws JsonProcessingException, Unsupporte
246248
this.factory.afterPropertiesSet();
247249
ObjectMapper objectMapper = this.factory.getObject();
248250

249-
DateTime dateTime = DateTime.parse("2011-12-03T10:15:30");
251+
DateTime dateTime = new DateTime(1322903730000L, DateTimeZone.UTC);
250252
assertEquals("\"2011-12-03\"", new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
251253
}
252254

@@ -260,7 +262,7 @@ public void customizeDefaultModulesWithSerializer() throws JsonProcessingExcepti
260262
this.factory.afterPropertiesSet();
261263
ObjectMapper objectMapper = this.factory.getObject();
262264

263-
DateTime dateTime = DateTime.parse("2011-12-03T10:15:30");
265+
DateTime dateTime = new DateTime(1322903730000L, DateTimeZone.UTC);
264266
assertEquals("\"2011-12-03\"", new String(objectMapper.writeValueAsBytes(dateTime), "UTF-8"));
265267
}
266268

0 commit comments

Comments
 (0)