NPE in SelectedValueComparator with null bound value [SPR-12001]

[spring-projects-issues]

Sebastian Anzani opened SPR-12001 and commented

In case the collection, used to preselect checkboxes values, contains some null values the following exception is thrown:

java.lang.NullPointerException
	org.springframework.web.servlet.tags.form.SelectedValueComparator.exhaustiveCompare(SelectedValueComparator.java:151)
	org.springframework.web.servlet.tags.form.SelectedValueComparator.exhaustiveCollectionCompare(SelectedValueComparator.java:140)
	org.springframework.web.servlet.tags.form.SelectedValueComparator.collectionCompare(SelectedValueComparator.java:112)
	org.springframework.web.servlet.tags.form.SelectedValueComparator.isSelected(SelectedValueComparator.java:89)
	org.springframework.web.servlet.tags.form.AbstractCheckedElementTag.isOptionSelected(AbstractCheckedElementTag.java:61)
	org.springframework.web.servlet.tags.form.AbstractCheckedElementTag.renderFromValue(AbstractCheckedElementTag.java:51)
	org.springframework.web.servlet.tags.form.AbstractCheckedElementTag.renderFromValue(AbstractCheckedElementTag.java:40)
	org.springframework.web.servlet.tags.form.CheckboxTag.writeTagDetails(CheckboxTag.java:90)
	org.springframework.web.servlet.tags.form.AbstractSingleCheckedElementTag.writeTagContent(AbstractSingleCheckedElementTag.java:87)
	org.springframework.web.servlet.tags.form.CheckboxTag.writeTagContent(CheckboxTag.java:53)
	org.springframework.web.servlet.tags.form.AbstractFormTag.doStartTagInternal(AbstractFormTag.java:84)
	org.springframework.web.servlet.tags.RequestContextAwareTag.doStartTag(RequestContextAwareTag.java:80)
	org.apache.jsp.page1_jsp._jspx_meth_form_005fcheckbox_005f0(page1_jsp.java:1505)

---

Affects: 3.2.10, 4.0.5, 4.0.6

Referenced from: commits a3ebf13, 5f77dce, 980f971

Backported to: 3.2.11

[spring-projects-issues]

Juergen Hoeller commented

SelectedValueComparator defensively handles null values in exhaustiveCompare now. This will be in the upcoming 4.1 RC1; to be backported to 4.0.7 and 3.2.11 as well.

Juergen