Skip to content

RestartClassLoader should implement LoadTimeWeaver [SPR-14374] #18947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jun 16, 2016 · 4 comments
Closed
Assignees
Labels
status: invalid An issue that we don't feel is valid

Comments

@spring-projects-issues
Copy link
Collaborator

Craig opened SPR-14374 and commented

org.springframework.boot.devtools.restart.classloader.RestartClassLoader should implement org.springframework.instrument.classloading.LoadTimeWeaver which would allow load time weaving to Just Work when using Spring Boot dev tools (ex, "mvn spring-boot:run").

With this change, org.springframework.instrument.classloading.ReflectiveLoadTimeWeaver would work with RestartClassLoader, making the @EnableLoadTimeWeaving annotation work as expected under Spring boot dev tools.


Affects: 4.3 GA

@spring-projects-issues
Copy link
Collaborator Author

Craig commented

Probably relevant: spring-projects/spring-boot#739

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

We'll have to deal with it on the Spring Boot issue tracker exclusively, since this JIRA tracker is only about the actual Spring Framework codebase... which RestartClassLoader isn't part of.

@spring-projects-issues
Copy link
Collaborator Author

Stéphane Nicoll commented

I am confused. RestartClassLoader is part of Spring Boot and you obviously know it's a separate issue tracker. What are you reporting here exactly?

@spring-projects-issues
Copy link
Collaborator Author

Craig commented

I noticed Spring Boot has a github issues system set up, but didn't know whether to report Spring Boot issues here or there (or if either one was acceptable). My apologies for the confusion, and thanks for the clarification.

@spring-projects-issues spring-projects-issues added status: invalid An issue that we don't feel is valid type: enhancement A general enhancement labels Jan 11, 2019
@spring-projects-issues spring-projects-issues removed the type: enhancement A general enhancement label Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

2 participants