AbstractValueAdaptingCache#toStoreValue should throw an exception if the value is null and allowNulls is false [SPR-15173]

[spring-projects-issues]

Stéphane Nicoll opened SPR-15173 and commented

If a Cache is configured to not allow null values, toStoreValue can still return null instead of throwing an exception. This leads to a non informative exception message if the underlying cache provider tries to store the value down the road.

---

Affects: 4.3.5

Issue Links:

• DATAREDIS-606 RedisCache Tests in Spring Data Redis 2.0.x builds fail testing null values
• AbstractValueAdaptingCache does not allow for flexible null value serialization [SPR-15693] #20252 AbstractValueAdaptingCache does not allow for flexible null value serialization

[spring-projects-issues]

Stéphane Nicoll commented

I did backport that fix until I realized I shouldn't so I've reverted the change in 4.3.x. Sorry about that.