Skip to content

Support for HtmlUnit 2.25+ [SPR-15319] #19882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Mar 6, 2017 · 2 comments
Closed

Support for HtmlUnit 2.25+ [SPR-15319] #19882

spring-projects-issues opened this issue Mar 6, 2017 · 2 comments
Assignees
@jhoeller
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
4.3.8

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Mar 6, 2017 •
edited
Loading

Juergen Hoeller opened SPR-15319 and commented

HtmlUnit 2.25 changed its WebRequest.getCharset() method to return a Charset instead of a String, breaking binary compatibility with our HtmlUnitRequestBuilder.

As of 5.0 RC1, we can simply require HtmlUnit 2.25+ and use the new signature accordingly. In 4.3.8, we can reflectively tolerate both signatures.

Issue Links:

Referenced from: commits 9de9761, e61e8d5
@spring-projects-issues
Copy link
Collaborator Author

Phil Webb commented

Annoying that that's changed in a minor patch release. Any plans for 2.25 support in 4.3.x?

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good point, let's tolerate both signatures in 4.3.x for the time being...

@spring-projects-issues spring-projects-issues added in: test Issues in the test module type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3.8 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
4.3.8
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues