Skip to content

Polish PathPattern parser [SPR-15531] #20090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue May 10, 2017 · 2 comments
Closed

Polish PathPattern parser [SPR-15531] #20090

spring-projects-issues opened this issue May 10, 2017 · 2 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented May 10, 2017

Arjen Poutsma opened SPR-15531 and commented

We should polish PathPattern and related classes so that they conform to Spring's code style, and also perform some other refactorings:

  • Move PathRemainingMatchInfo into PathPattern
  • Reduce the amount of public classes in org.springframework.web.util.patterns.
  • Rename the plural patterns in the package name to pattern?

Issue Links:

Referenced from: commits 67881a5

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

apoutsma, I've started working on this since I wanted to move ParsingPathMatcher to util.patterns and stumbled into related issues from there. At this point I've done everything you suggested already, except the patterns->pattern renaming at the package level.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've also renamed web.util.patterns to web.util.pattern right away, in order to avoid yet another change of ParsingPathMatcher's new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants