Skip to content

Upgrade to Gradle 4.8(.1) [SPR-16475] #21020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Feb 7, 2018 · 10 comments
Closed

Upgrade to Gradle 4.8(.1) [SPR-16475] #21020

spring-projects-issues opened this issue Feb 7, 2018 · 10 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Feb 7, 2018

Juergen Hoeller opened SPR-16475 and commented

Gradle 4.5 is out in the meantime, with even a 4.5.1 maintenance release available already... and now Gradle 4.6 goes RC, so we should go straight to that one.

Update: Gradle 4.7 is out now. Maybe we'll even get Gradle 4.8 in time for our 5.1 RC1...


Affects: 5.0.3

Issue Links:

Referenced from: commits 17c16ea, 853d30d, eaffcbe

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

A line from our spring-beans.gradle file turns out to break against Gradle 4.5:

compileGroovy.dependsOn = compileGroovy.taskDependencies.values - 'compileJava'

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

FYI: Gradle 4.6 was released just a few hours ago...

https://twitter.com/gradle/status/968872401650860032

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Mar 30, 2018

Sam Brannen commented

Related to #21213

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Merged PR into master in the following commit: 17c16ea

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Reopening for a Gradle 4.7 upgrade... reusing this issue since we haven't released against it yet.

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Upgraded to Gradle 4.7 in commit: 5811d13

Upgrade to Gradle 4.8 in commit: 2390695

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Sam Brannen, thanks for your efforts there! Since master is on Gradle 4.8 now, including all of Gradle's JDK 10 related changes already, I consider this good enough for our Spring Framework 5.1 RC1 in July... just possibly upgrading to Gradle 4.8.1 (if any) in the course of this ticket still.

Let's use a separate ticket for any further major Gradle upgrades, individually scheduled for 5.1.x or 5.2.

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Sounds like a good plan!

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I've updated the build to Gradle 4.8.1 now.

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

I'm guessing you mean locally, but... OK. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants