Skip to content

Request backport of SPR-17307 [SPR-17349] #21883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Oct 5, 2018 · 1 comment
Closed

Request backport of SPR-17307 [SPR-17349] #21883

spring-projects-issues opened this issue Oct 5, 2018 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression)

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 5, 2018 •
edited
Loading

Samuel Bratton opened SPR-17349 and commented

Hi,

Thanks for the performance improvement #21840. 

I would like to request it be back ported to 4.x and 5.0. Our goal is to benefit from the performance improvement in apps built on spring boot 1.5.x  and spring boot 2.0.x  

Affects: 4.3.19, 5.0.9

Issue Links:
@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 5, 2018 •
edited
Loading

Juergen Hoeller commented

So you have a scenario with several event listeners being invoked for a given event in a hot code path? Otherwise this change won't make much difference to begin with...

As for a backport, this quite significantly changes the cached listener representation, so I'm hesitant to backport it to 4.3.19 at this point. However, we can consider 5.0.10 there; I'll mark #21840 itself accordingly, closing this separate backport request ticket.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues removed the type: enhancement A general enhancement label Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues